r82924 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82923‎ | r82924 | r82925 >
Date:02:26, 28 February 2011
Author:tstarling
Status:ok
Tags:
Comment:
Minor fix in ZIP64 code from r82783. Note that this code is, before and after this fix, untested and unused. I only committed it because I thought it might be a helpful starting point for future development.
Modified paths:
  • /trunk/phase3/includes/ZipDirectoryReader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ZipDirectoryReader.php
——@@ -439,7 +439,6 @@
440440 );
441441
442442 $extraPos = 0;
443 - $extraField = $data['extra field'];
444443 while ( $extraPos < strlen( $extraField ) ) {
445444 $extra = $this->unpack( $extraField, $extraHeaderInfo, $extraPos );
446445 $extraPos += $extraHeaderSize;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82783* (bug 24230) Added JAR detection. ZIP archives containing a .class file will...tstarling04:51, 25 February 2011

Status & tagging log