r82914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82913‎ | r82914 | r82915 >
Date:21:11, 27 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Tweak documentation

Fix constant use in UploadTest
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/UploadTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/UploadTest.php
@@ -106,7 +106,7 @@
107107 unlink( $filename );
108108
109109 $this->assertEquals(
110 - array( 'status' => UploadTestHandler::OK ), $result );
 110+ array( 'status' => UploadBase::OK ), $result );
111111
112112 $wgMaxUploadSize = $savedGlobal; // restore global
113113 }
Index: trunk/phase3/includes/upload/UploadBase.php
@@ -707,7 +707,7 @@
708708 * API request to find this stashed file again.
709709 *
710710 * @param $key String: (optional) the session key used to find the file info again. If not supplied, a key will be autogenerated.
711 - * @return File stashed file
 711+ * @return UploadStashFile stashed file
712712 */
713713 public function stashSessionFile( $key = null ) {
714714 $stash = RepoGroup::singleton()->getLocalRepo()->getUploadStash();
Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -701,6 +701,8 @@
702702
703703 /**
704704 * Get an UploadStash associated with this repo.
 705+ *
 706+ * @return UploadStash
705707 */
706708 function getUploadStash() {
707709 return new UploadStash( $this );

Status & tagging log