r82912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82911‎ | r82912 | r82913 >
Date:21:06, 27 February 2011
Author:demon
Status:ok
Tags:
Comment:
Partial merge r82461, close() the reader when we're done with it.

Probably not enough to fix the OOM issues here, since we've pretty much established that XMLReader is unacceptably slow (eg: r66267, r77638)
Modified paths:
  • /branches/wmf/1.17wmf1/includes/media/SVGMetadataExtractor.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/media/SVGMetadataExtractor.php
@@ -113,6 +113,8 @@
114114 }
115115 }
116116
 117+ $this->reader->close();
 118+
117119 return true;
118120 }
119121

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66267Rewrite of XML Dump Processing:...werdna13:28, 12 May 2010
r82461Close the xmlreader when we are done with it.hartman15:42, 19 February 2011

Status & tagging log