r82906 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82905‎ | r82906 | r82907 >
Date:20:14, 27 February 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Use realy minus sign, like for WikDiff.php and wikidiff.cpp

Bug 26038
Modified paths:
  • /trunk/extensions/wikidiff2/wikidiff2.cpp (modified) (history)

Diff [purge]

Index: trunk/extensions/wikidiff2/wikidiff2.cpp
@@ -129,7 +129,7 @@
130130 void Wikidiff2::printDelete(const String & line)
131131 {
132132 result += "<tr>\n"
133 - " <td class=\"diff-marker\">-</td>\n"
 133+ " <td class=\"diff-marker\">−</td>\n"
134134 " <td class=\"diff-deletedline\">";
135135 printTextWithDiv(line);
136136 result += "</td>\n"
@@ -149,7 +149,7 @@
150150
151151 // print twice; first for left side, then for right side
152152 result += "<tr>\n"
153 - " <td class=\"diff-marker\">-</td>\n"
 153+ " <td class=\"diff-marker\">−</td>\n"
154154 " <td class=\"diff-deletedline\"><div>";
155155 printWordDiffSide(worddiff, false);
156156 result += "</div></td>\n"

Follow-up revisions

RevisionCommit summaryAuthorDate
r83886* Fixed bug 27993: in Wikidiff2::explodeWords(), the iterator pBrk is invalid...tstarling11:51, 14 March 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:12, 14 March 2011

Please update tests too.

Status & tagging log