r82892 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82891‎ | r82892 | r82893 >
Date:14:54, 27 February 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Moved reference detection to Cite extension (per r82891).
Modified paths:
  • /trunk/extensions/InlineEditor/InlineEditor.class.php (modified) (history)
  • /trunk/extensions/InlineEditor/InlineEditor.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InlineEditor/InlineEditor.class.php
@@ -430,18 +430,4 @@
431431
432432 return Html::rawElement( 'div', array( 'class' => 'editbox' ), $form );
433433 }
434 -
435 - /**
436 - * Make sure the entire page rerenders when rendering a reference.
437 - *
438 - * @todo: FIXME: This should be moved over to the Cite extension, and something like this should
439 - * be included in other extensions as well. In the future, something smarter should be
440 - * implemented, to be able to only rerender the dependencies and not the entire page.
441 - *
442 - * @param $markedWiki string
443 - * @return bool
444 - */
445 - public static function partialRenderCite( $markedWiki ) {
446 - return ( preg_match( '/<ref[^\/]*?>.*?<\/ref>|<ref.*?\/>/is', $markedWiki) <= 0) ;
447 - }
448434 }
Index: trunk/extensions/InlineEditor/InlineEditor.php
@@ -46,7 +46,6 @@
4747
4848 $wgHooks['InlineEditorPartialBeforeParse'] = array();
4949 $wgHooks['InlineEditorPartialAfterParse'] = array();
50 -$wgHooks['InlineEditorPartialBeforeParse'][] = 'InlineEditor::partialRenderCite';
5150
5251 // i18n messages
5352 $wgExtensionMessagesFiles['InlineEditor'] = $dir . 'InlineEditor.i18n.php';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82891Added hook to support partial rendering for the InlineEditor extension. Doesn...janpaul12314:50, 27 February 2011

Status & tagging log