r82840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82839‎ | r82840 | r82841 >
Date:10:55, 26 February 2011
Author:demon
Status:ok
Tags:
Comment:
Null -> null, reorder docs to match signature
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -446,14 +446,14 @@
447447 * Build a drop-down box from a textual list.
448448 *
449449 * @param $name Mixed: Name and id for the drop-down
450 - * @param $class Mixed: CSS classes for the drop-down
 450+ * @param $list Mixed: Correctly formatted text (newline delimited) to be used to generate the options
451451 * @param $other Mixed: Text for the "Other reasons" option
452 - * @param $list Mixed: Correctly formatted text (newline delimited) to be used to generate the options
453452 * @param $selected Mixed: Option which should be pre-selected
 453+ * @param $class Mixed: CSS classes for the drop-down
454454 * @param $tabindex Mixed: Value of the tabindex attribute
455455 * @return string
456456 */
457 - public static function listDropDown( $name= '', $list = '', $other = '', $selected = '', $class = '', $tabindex = Null ) {
 457+ public static function listDropDown( $name= '', $list = '', $other = '', $selected = '', $class = '', $tabindex = null ) {
458458 $optgroup = false;
459459
460460 $options = self::option( $other, 'other', $selected === 'other' );

Status & tagging log