r82809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82808‎ | r82809 | r82810 >
Date:19:51, 25 February 2011
Author:kaldari
Status:deferred
Tags:
Comment:
using jQuery from ResourceLoader instead of rolling our own
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -13,15 +13,12 @@
1414
1515 public static $modules = array(
1616 'ext.uploadWizard' => array(
 17+ 'dependencies' => array(
 18+ 'jquery.ui.dialog',
 19+ 'jquery.ui.datepicker',
 20+ 'jquery.ui.progressbar'
 21+ ),
1722 'scripts' => array(
18 - // jquery ui
19 - // FIXME: These can be replaced with dependencies when pre-RL compat is dropped
20 - 'resources/jquery.ui/jquery.ui.core.js',
21 - 'resources/jquery.ui/jquery.ui.widget.js',
22 - 'resources/jquery.ui/jquery.ui.button.js',
23 - 'resources/jquery.ui/jquery.ui.dialog.js',
24 - 'resources/jquery.ui/jquery.ui.datepicker.js',
25 - 'resources/jquery.ui/jquery.ui.progressbar.js',
2623
2724 // jquery interface helpers
2825 'resources/jquery/jquery.tipsy.js',
@@ -126,12 +123,6 @@
127124 'resources/jquery/jquery.arrowSteps.css',
128125 'resources/jquery/jquery.mwCoolCats.css',
129126 'resources/jquery/jquery.removeCtrl.css',
130 - 'resources/jquery.ui/themes/vector/jquery.ui.core.css',
131 - 'resources/jquery.ui/themes/vector/jquery.ui.theme.css',
132 - 'resources/jquery.ui/themes/vector/jquery.ui.button.css',
133 - 'resources/jquery.ui/themes/vector/jquery.ui.dialog.css',
134 - 'resources/jquery.ui/themes/vector/jquery.ui.datepicker.css',
135 - 'resources/jquery.ui/themes/vector/jquery.ui.progressbar.css',
136127 ),
137128 'messages' => array(
138129 'linktest',
Index: trunk/extensions/UploadWizard/UploadWizard.php
@@ -55,7 +55,7 @@
5656 $wgExtensionJavascriptModules[ 'UploadWizard' ] = 'extensions/UploadWizard';
5757
5858 // Disable ResourceLoader support by default, it's currently broken
59 -$wgUploadWizardDisableResourceLoader = true;
 59+// $wgUploadWizardDisableResourceLoader = true;
6060
6161 // for ResourceLoader
6262 $wgHooks['ResourceLoaderRegisterModules'][] = 'UploadWizardHooks::resourceLoaderRegisterModules';

Status & tagging log