r82734 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82733‎ | r82734 | r82735 >
Date:17:04, 24 February 2011
Author:reedy
Status:ok
Tags:
Comment:
More member variable documentation
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_Hash.php
@@ -826,7 +826,15 @@
827827 */
828828 var $parser;
829829
830 - var $preprocessor, $title;
 830+ /**
 831+ * @var Preprocessor
 832+ */
 833+ var $preprocessor;
 834+
 835+ /**
 836+ * @var Title
 837+ */
 838+ var $title;
831839 var $titleCache;
832840
833841 /**
@@ -894,8 +902,7 @@
895903 return $root;
896904 }
897905
898 - if ( ++$this->parser->mPPNodeCount > $this->parser->mOptions->getMaxPPNodeCount() )
899 - {
 906+ if ( ++$this->parser->mPPNodeCount > $this->parser->mOptions->getMaxPPNodeCount() ) {
900907 return '<span class="error">Node-count limit exceeded</span>';
901908 }
902909 if ( $expansionDepth > $this->parser->mOptions->getMaxPPExpandDepth() ) {
@@ -1203,6 +1210,8 @@
12041211
12051212 /**
12061213 * Returns true if the infinite loop check is OK, false if a loop is detected
 1214+ *
 1215+ * @param $title Title
12071216 */
12081217 function loopCheck( $title ) {
12091218 return !isset( $this->loopCheckHash[$title->getPrefixedDBkey()] );
Index: trunk/phase3/includes/EditPage.php
@@ -42,7 +42,14 @@
4343 const AS_IMAGE_REDIRECT_ANON = 233;
4444 const AS_IMAGE_REDIRECT_LOGGED = 234;
4545
 46+ /**
 47+ * @var Article
 48+ */
4649 var $mArticle;
 50+
 51+ /**
 52+ * @var Title
 53+ */
4754 var $mTitle;
4855 private $mContextTitle = null;
4956 var $action;

Status & tagging log