r82725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82724‎ | r82725 | r82726 >
Date:15:18, 24 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Always set the href, even if it's to ""
Modified paths:
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.php
@@ -150,9 +150,15 @@
151151 $str .= sprintf( "Narayam.shortcut.key= '%s';\n", $wgNarayamConfig['shortcut_key'] );
152152 $str .= sprintf( "Narayam.checkbox.text= '%s ('+Narayam.shortcut.toString()+')';\n", wfMsgForContent( 'narayam-toggle-ime' ) /* $wgNarayamConfig['checkbox']['text'] */ );
153153 $title = Title::newFromText( wfMsgForContent( 'narayam-help-page' ) );
 154+
 155+ $target = '';
 156+
154157 if ( $title ) {
155 - $str .= sprintf( "Narayam.checkbox.href= '%s';\n", $title->getFullURL() );
 158+ $target = $title->getFullURL();
156159 }
 160+
 161+ $str .= sprintf( "Narayam.checkbox.href= '%s';\n", $target );
 162+
157163 $str .= sprintf( "Narayam.checkbox.tooltip= '%s';\n", wfMsgForContent( 'narayam-checkbox-tooltip' ) );
158164 // $str .= 'Narayam.default_state = ' . Narayam::boolToString($wgNarayamConfig['default_state']) . ";\n";
159165 $str .= "Narayam.schemes = [\n";

Status & tagging log