r82692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82691‎ | r82692 | r82693 >
Date:19:56, 23 February 2011
Author:hashar
Status:ok
Tags:
Comment:
Minor typos

(Trow -> Throw, Sens->sense), follow up CR on r82577
Modified paths:
  • /trunk/phase3/includes/Namespace.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Namespace.php
@@ -54,8 +54,8 @@
5555 private static $alwaysCapitalizedNamespaces = array( NS_SPECIAL, NS_USER, NS_MEDIAWIKI );
5656
5757 /**
58 - * Trow an exception when trying to get the subject or talk page
59 - * for a given namespace where it does not make sens.
 58+ * Throw an exception when trying to get the subject or talk page
 59+ * for a given namespace where it does not make sense.
6060 * Special namespaces are defined in includes/define.php and have
6161 * a value below 0 (ex: NS_SPECIAL = -1 , NS_MEDIA = -2)
6262 *
@@ -63,7 +63,7 @@
6464 */
6565 private static function isMethodValidFor( $index, $method ) {
6666 if( $index < NS_MAIN ) {
67 - throw new MWException( "$method does not make any sens for given namespace $index" );
 67+ throw new MWException( "$method does not make any sense for given namespace $index" );
6868 return false;
6969 }
7070 return true;

Sign-offs

UserFlagDate
Lcawteinspected21:22, 28 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82577improve namespace related methods...hashar22:17, 21 February 2011

Status & tagging log