r82678 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82677‎ | r82678 | r82679 >
Date:16:34, 23 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r82473, r82572, r82574, r82601, r82608, r82654
Modified paths:
  • /branches/wmf/1.17wmf1/RELEASE-NOTES (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/CodeReview/ui/CodeCommentsListView.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/Collection/Collection.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/parser/Parser.php (modified) (history)
  • /branches/wmf/1.17wmf1/languages/messages/MessagesPt.php (modified) (history)
  • /branches/wmf/1.17wmf1/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/skins/common/wikibits.js
@@ -387,16 +387,18 @@
388388 };
389389
390390 window.getInnerText = function( el ) {
391 - if ( el.getAttribute( 'data-sort-value' ) !== null ) {
392 - return el.getAttribute( 'data-sort-value' );
393 - }
394 -
395391 if ( typeof el == 'string' ) {
396392 return el;
397393 }
398394 if ( typeof el == 'undefined' ) {
399395 return el;
400396 }
 397+ // Custom sort value through 'data-sort-value' attribute
 398+ // (no need to prepend hidden text to change sort value)
 399+ if ( el.nodeType && el.getAttribute( 'data-sort-value' ) !== null ) {
 400+ // Make sure it's a valid DOM element (.nodeType) and that the attribute is set (!null)
 401+ return el.getAttribute( 'data-sort-value' );
 402+ }
401403 if ( el.textContent ) {
402404 return el.textContent; // not needed but it is faster
403405 }
Index: branches/wmf/1.17wmf1/extensions/Collection/Collection.php
@@ -187,6 +187,7 @@
188188 ),
189189 'ext.collection.checkLoadFromLocalStorage' => $collResourceTemplate + array(
190190 'scripts' => 'check_load_from_localstorage.js',
 191+ 'styles' => 'bookcreator.css',
191192 'dependencies' => 'ext.collection.jquery.jstorage'
192193 )
193194 );
Index: branches/wmf/1.17wmf1/extensions/ProofreadPage/ProofreadPage_body.php
@@ -975,8 +975,8 @@
976976 if( !preg_match( $page_regexp, $text, $m ) ) {
977977 $this->load_index( $wgTitle );
978978 list( $index_title, $prev_title, $next_title, $header, $footer, $css, $edit_width ) = $this->navigation( $wgTitle );
979 - $new_text = "<noinclude><pagequality level=\"1\" user=\"$username\" />"
980 - ."$header\n\n\n</noinclude>$text<noinclude>\n$footer</noinclude>";
 979+ $new_text = "<noinclude><pagequality level=\"1\" user=\"$username\" /><div class=\"pagetext\">"
 980+ ."$header\n\n\n</noinclude>$text<noinclude>\n$footer</div></noinclude>";
981981 return array( -1, null, $new_text );
982982 }
983983
Property changes on: branches/wmf/1.17wmf1/extensions/ProofreadPage/ProofreadPage_body.php
___________________________________________________________________
Modified: svn:mergeinfo
984984 Merged /trunk/extensions/ProofreadPage/ProofreadPage_body.php:r82574,82601,82654
985985 Merged /trunk/phase3/extensions/ProofreadPage/ProofreadPage_body.php:r82473,82572,82608
Index: branches/wmf/1.17wmf1/extensions/CodeReview/ui/CodeCommentsListView.php
@@ -67,7 +67,7 @@
6868 switch( $name ) {
6969 case 'cc_rev_id':
7070 return $this->mView->skin->link(
71 - SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $value . '#code-comments' ),
 71+ SpecialPage::getSafeTitleFor( 'Code', $this->mRepo->getName() . '/' . $value . '#code-comments' ),
7272 htmlspecialchars( $value ) );
7373 case 'cr_status':
7474 return $this->mView->skin->link(
Index: branches/wmf/1.17wmf1/includes/parser/Parser.php
@@ -320,8 +320,8 @@
321321
322322 /**
323323 * A converted title will be provided in the output object if title and
324 - * content conversion are enabled, the article text does not contain
325 - * a conversion-suppressing double-underscore tag, and no
 324+ * content conversion are enabled, the article text does not contain
 325+ * a conversion-suppressing double-underscore tag, and no
326326 * {{DISPLAYTITLE:...}} is present. DISPLAYTITLE takes precedence over
327327 * automatic link conversion.
328328 */
@@ -478,7 +478,9 @@
479479
480480 $flags = PPFrame::NO_ARGS | PPFrame::NO_TEMPLATES;
481481 $dom = $this->preprocessToDom( $text, self::PTD_FOR_INCLUSION );
482 - return $this->getPreprocessor()->newFrame()->expand( $dom, $flags );
 482+ $text = $this->getPreprocessor()->newFrame()->expand( $dom, $flags );
 483+ $text = $this->mStripState->unstripBoth( $text );
 484+ return $text;
483485 }
484486
485487 /**
Property changes on: branches/wmf/1.17wmf1/includes/parser/Parser.php
___________________________________________________________________
Modified: svn:mergeinfo
486488 Merged /trunk/phase3/includes/parser/Parser.php:r82473,82572,82608
Index: branches/wmf/1.17wmf1/languages/messages/MessagesPt.php
@@ -81,7 +81,7 @@
8282 );
8383
8484 $separatorTransformTable = array( ',' => ' ', '.' => ',' );
85 -$linkTrail = '/^([áâãàéêçíóôõúüa-z]+)(.*)$/sDu'; # Bug 21168
 85+$linkTrail = '/^([áâãàéêẽçíòóôõq̃úüűũa-z]+)(.*)$/sDu'; # Bug 21168, 27633
8686
8787 $specialPageAliases = array(
8888 'DoubleRedirects' => array( 'Redireccionamentos_duplos', 'Redirecionamentos_duplos' ),
Index: branches/wmf/1.17wmf1/RELEASE-NOTES
@@ -619,6 +619,8 @@
620620 * Minangkabau (min) (new)
621621 * Dutch (informal) (nl-informal) (new)
622622 * Rusyn (rue) (new)
 623+* Link trail added for sl and sh
 624+* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)
623625
624626 * (bug 23156) Commafy and search normalization updated for Belarusian
625627 (Taraškievica).
Property changes on: branches/wmf/1.17wmf1/RELEASE-NOTES
___________________________________________________________________
Modified: svn:mergeinfo
626628 Merged /trunk/phase3/RELEASE-NOTES:r82473,82572,82608

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82473(Bug #27467) preload can leave UNIQ...mah19:18, 19 February 2011
r82572Follow-up r73270. Moving the attribute check down to the point where it's for...krinkle20:36, 21 February 2011
r82574Fixup comment linking in CodeReview from /comments...reedy21:12, 21 February 2011
r82601add missing divthomasv13:07, 22 February 2011
r82608* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)...reedy15:33, 22 February 2011
r82654add CSS to (start) book creator pagejojo10:47, 23 February 2011

Status & tagging log