r82670 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82669‎ | r82670 | r82671 >
Date:14:26, 23 February 2011
Author:demon
Status:deferred
Tags:
Comment:
Fix backwards canCreateAccounts() check, remove setting search_path for $wgDBuser, since this is set per-session on open()
Modified paths:
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -162,8 +162,7 @@
163163 }
164164
165165 // Validate the create checkbox
166 - $canCreate = $this->canCreateAccounts();
167 - if ( $canCreate ) {
 166+ if ( !$this->canCreateAccounts() ) {
168167 $this->setVar( '_CreateDBAccount', false );
169168 $create = false;
170169 } else {
@@ -287,7 +286,6 @@
288287 if ( $res !== true && !( $res instanceOf ResultWrapper ) ) {
289288 $status->fatal( 'config-install-user-failed', $this->getVar( 'wgDBuser' ), $res );
290289 }
291 - $this->db->query("ALTER USER $safeuser SET search_path = $safeschema");
292290 }
293291
294292 return $status;

Status & tagging log