r82644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82643‎ | r82644 | r82645 >
Date:23:40, 22 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r82641, set default for 2nd param

Fix caller in SpecialLinkSearch.php
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialLinkSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialLinkSearch.php
@@ -179,7 +179,7 @@
180180 /**
181181 * Override to check query validity.
182182 */
183 - function doQuery( $limit, $offset = false ) {
 183+ function doQuery( $offset = false, $limit = false ) {
184184 global $wgOut;
185185 list( $this->mMungedQuery, ) = LinkSearchPage::mungeQuery( $this->mQuery, $this->mProt );
186186 if( $this->mMungedQuery === false ) {
@@ -188,7 +188,7 @@
189189 // For debugging
190190 // Generates invalid xhtml with patterns that contain --
191191 //$wgOut->addHTML( "\n<!-- " . htmlspecialchars( $this->mMungedQuery ) . " -->\n" );
192 - parent::doQuery( $limit, $offset );
 192+ parent::doQuery( $offset, $limit );
193193 }
194194 }
195195
Index: trunk/phase3/includes/QueryPage.php
@@ -383,7 +383,7 @@
384384 /**
385385 * Somewhat deprecated, you probably want to be using execute()
386386 */
387 - function doQuery( $offset = false, $limit ) {
 387+ function doQuery( $offset = false, $limit = false ) {
388388 if ( $this->isCached() && $this->isCacheable() ) {
389389 return $this->fetchFromCache( $limit, $offset );
390390 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82641Followup r78786, per complaints on r82636, revert parameter ordering...reedy23:22, 22 February 2011

Status & tagging log