r82619 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r82618‎ \| r82619 \| r82620 >
Date:	18:22, 22 February 2011
Author:	yaron
Status:	deferred
Tags:
Comment:	Changed all calls to (deprecated) Linker::makeKnownLinkObj() method to use new SFUtils::linkForSpecialPage() method instead
Modified paths:	/trunk/extensions/SemanticForms/specials/SF_CreateCategory.php (modified) (history) /trunk/extensions/SemanticForms/specials/SF_CreateClass.php (modified) (history) /trunk/extensions/SemanticForms/specials/SF_CreateForm.php (modified) (history) /trunk/extensions/SemanticForms/specials/SF_CreateTemplate.php (modified) (history) /trunk/extensions/SemanticForms/specials/SF_Forms.php (modified) (history) /trunk/extensions/SemanticForms/specials/SF_Templates.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_CreateCategory.php
—	—	@@ -99,8 +99,7 @@
100	100	$subcategory_label = wfMsg( 'sf_createcategory_makesubcategory' );
101	101	$categories = SFUtils::getCategoriesForPage();
102	102	$sk = $wgUser->getSkin();
103		~~- $cf = SpecialPage::getPage( 'CreateForm' );~~
104		~~- $create_form_link = $sk->makeKnownLinkObj( $cf->getTitle(), $cf->getDescription() );~~
	103	+ $create_form_link = SFUtils::linkForSpecialPage( $sk, 'CreateForm' );
105	104	$text .= <<<END
106	105	</select>
107	106	<p>$subcategory_label
Index: trunk/extensions/SemanticForms/specials/SF_Forms.php
—	—	@@ -52,8 +52,7 @@
53	53	SFUtils::loadMessages();
54	54
55	55	$sk = $wgUser->getSkin();
56		~~- $cf = SpecialPage::getPage( 'CreateForm' );~~
57		~~- $create_form_link = $sk->makeKnownLinkObj( $cf->getTitle(), $cf->getDescription() );~~
	56	+ $create_form_link = SFUtils::linkForSpecialPage( $sk, 'CreateForm' );
58	57	$header = "<p>" . $create_form_link . ".</p>\n";
59	58	$header .= '<p>' . wfMsg( 'sf_forms_docu' ) . "</p><br />\n";
60	59	return $header;
Index: trunk/extensions/SemanticForms/specials/SF_CreateForm.php
—	—	@@ -243,8 +243,7 @@
244	244	$preview_button_text = wfMsg( 'preview' );
245	245	$add_button_text = wfMsg( 'sf_createform_add' );
246	246	$sk = $wgUser->getSkin();
247		~~- $ct = SpecialPage::getPage( 'CreateTemplate' );~~
248		~~- $create_template_link = $sk->makeKnownLinkObj( $ct->getTitle(), $ct->getDescription() );~~
	247	+ $create_template_link = SFUtils::linkForSpecialPage( $sk, 'CreateTemplate' );
249	248	$text .= <<<END
250	249	<input type="submit" name="add_field" value="$add_button_text" /></p>
251	250	<br />
Index: trunk/extensions/SemanticForms/specials/SF_CreateClass.php
—	—	@@ -119,14 +119,10 @@
120	120	// link to them at the top of the page
121	121	$sk = $wgUser->getSkin();
122	122	$creation_links = array();
123		~~- $cp = SpecialPage::getPage( 'CreateProperty' );~~
124		~~- $creation_links[] = $sk->makeKnownLinkObj( $cp->getTitle(), $cp->getDescription() );~~
125		~~- $ct = SpecialPage::getPage( 'CreateTemplate' );~~
126		~~- $creation_links[] = $sk->makeKnownLinkObj( $ct->getTitle(), $ct->getDescription() );~~
127		~~- $cf = SpecialPage::getPage( 'CreateForm' );~~
128		~~- $creation_links[] = $sk->makeKnownLinkObj( $cf->getTitle(), $cf->getDescription() );~~
129		~~- $cc = SpecialPage::getPage( 'CreateCategory' );~~
130		~~- $creation_links[] = $sk->makeKnownLinkObj( $cc->getTitle(), $cc->getDescription() );~~
	123	+ $creation_links[] = SFUtils::linkForSpecialPage( $sk, 'CreateProperty' );
	124	+ $creation_links[] = SFUtils::linkForSpecialPage( $sk, 'CreateTemplate' );
	125	+ $creation_links[] = SFUtils::linkForSpecialPage( $sk, 'CreateForm' );
	126	+ $creation_links[] = SFUtils::linkForSpecialPage( $sk, 'CreateCategory' );
131	127	$create_class_docu = wfMsg( 'sf_createclass_docu', $wgLang->listToText( $creation_links ) );
132	128	$leave_field_blank = wfMsg( 'sf_createclass_leavefieldblank' );
133	129	$form_name_label = wfMsg( 'sf_createform_nameinput' );
Index: trunk/extensions/SemanticForms/specials/SF_Templates.php
—	—	@@ -52,8 +52,7 @@
53	53	SFUtils::loadMessages();
54	54
55	55	$sk = $wgUser->getSkin();
56		~~- $ct = SpecialPage::getPage( 'CreateTemplate' );~~
57		~~- $create_template_link = $sk->makeKnownLinkObj( $ct->getTitle(), $ct->getDescription() );~~
	56	+ $create_template_link = SFUtils::linkForSpecialPage( $sk, 'CreateTemplate' );
58	57	$header = "<p>" . $create_template_link . ".</p>\n";
59	58	$header .= '<p>' . wfMsg( 'sf_templates_docu' ) . "</p><br />\n";
60	59	return $header;
Index: trunk/extensions/SemanticForms/specials/SF_CreateTemplate.php
—	—	@@ -183,8 +183,7 @@
184	184
185	185	END;
186	186	$sk = $wgUser->getSkin();
187		~~- $cp = SpecialPage::getPage( 'CreateProperty' );~~
188		~~- $create_property_link = $sk->makeKnownLinkObj( $cp->getTitle(), $cp->getDescription() );~~
	187	+ $create_property_link = SFUtils::linkForSpecialPage( $sk, 'CreateProperty' );
189	188	$text .= " <br /><hr /><br />\n";
190	189	$text .= " " . Xml::tags( 'p', null, $create_property_link . '.' ) . "\n";
191	190