r82584 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82583‎ | r82584 | r82585 >
Date:00:03, 22 February 2011
Author:laner
Status:deferred
Tags:
Comment:
Fixing bug reported from LP:668589
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -169,7 +169,7 @@
170170 if ( $this->ldapconn ) {
171171 $this->printDebug( "Successfully connected", NONSENSITIVE );
172172
173 - $searchstring = $this->getSearchString( $this->ldapconn, $username );
 173+ $searchstring = $this->getSearchString( $username );
174174
175175 // If we are using auto authentication, and we got
176176 // anything back, then the user exists.
@@ -809,10 +809,10 @@
810810 $this->printDebug( "Entering validDomain", NONSENSITIVE );
811811
812812 if ( in_array( $domain, $wgLDAPDomainNames ) || ( $wgLDAPUseLocal && 'local' == $domain ) ) {
813 - $this->printDebug( "User is using a valid domain.", NONSENSITIVE );
 813+ $this->printDebug( "User is using a valid domain ($domain).", NONSENSITIVE );
814814 return true;
815815 } else {
816 - $this->printDebug( "User is not using a valid domain.", NONSENSITIVE );
 816+ $this->printDebug( "User is not using a valid domain ($domain).", NONSENSITIVE );
817817 return false;
818818 }
819819 }

Status & tagging log