r82542 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82541‎ | r82542 | r82543 >
Date:00:11, 21 February 2011
Author:aaron
Status:deferred
Tags:
Comment:
Follow-up r82541: never call setReviewNotes() for printable output
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -403,7 +403,7 @@
404404 protected function showUnreviewedPage( $tag, $prot ) {
405405 global $wgOut, $wgContLang;
406406 if ( $wgOut->isPrintable() ) {
407 - return;
 407+ return; // all this function does is add notices; don't show them
408408 }
409409 $icon = FlaggedRevsXML::draftStatusIcon();
410410 // Simple icon-based UI
@@ -592,9 +592,9 @@
593593 FlaggedRevsXML::addTagRatings( $flags ) . '</div>';
594594 }
595595 }
 596+ # Load the review notes which will be shown by onSkinAfterContent
 597+ $this->setReviewNotes( $frev );
596598 }
597 - # Load the review notes which will be shown by onSkinAfterContent
598 - $this->setReviewNotes( $frev );
599599
600600 # Check if this is a redirect...
601601 $text = $frev->getRevText();
@@ -675,7 +675,9 @@
676676 }
677677
678678 # Load the review notes which will be shown by onSkinAfterContent
679 - $this->setReviewNotes( $srev );
 679+ if ( !$wgOut->isPrintable() ) {
 680+ $this->setReviewNotes( $srev );
 681+ }
680682
681683 # Get parsed stable version and output HTML
682684 $parserOut = FlaggedRevs::getPageCache( $this->article, $wgUser );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82541* Don't make a whole new bar for diff-on-draft ("flaggedrevsviewdiffs" prefer...aaron23:55, 20 February 2011

Status & tagging log