r82531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82530‎ | r82531 | r82532 >
Date:19:53, 20 February 2011
Author:yaron
Status:deferred
Tags:
Comment:
Temporary fix to problem of too-small height and width for popup window
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -476,17 +476,21 @@
477477
478478 iframe[0].style.overflow = "auto";
479479
480 - if ( docWidth > availW * .85 ) {
 480+ // For now, just ignore docWidth and docHeight - at
 481+ // least on Vector, they're getting set to values
 482+ // that are far too small.
 483+ // TODO: fix this
 484+ //if ( docWidth > availW * .85 ) {
481485 w = ( availW * .8 );
482 - } else {
483 - w = docWidth + 20;
484 - }
 486+ //} else {
 487+ // w = docWidth + 20;
 488+ //}
485489
486 - if ( docHeight > availH * .85 ) {
 490+ //if ( docHeight > availH * .85 ) {
487491 h = ( availH * .8 );
488 - } else {
489 - h = docHeight + 20;
490 - }
 492+ //} else {
 493+ // h = docHeight + 20;
 494+ //}
491495
492496 } else {
493497 iframe[0].style.overflow = "hidden";
@@ -593,4 +597,4 @@
594598 this.handlePopupFormInput = handlePopupFormInput;
595599 this.handlePopupFormLink = handlePopupFormLink;
596600
597 -}
\ No newline at end of file
 601+}