r82519 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82518‎ | r82519 | r82520 >
Date:17:44, 20 February 2011
Author:hashar
Status:ok
Tags:
Comment:
Force wgDebugTimestamps false

Test GlobalTest::testDebugFunctionTest() does not take into account the setting
$wgDebugTimestamps = true. Setting it false makes sure the tests pass though
not testing the settings :(
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/GlobalTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/GlobalTest.php
——@@ -492,10 +492,11 @@
493493
494494 function testDebugFunctionTest() {
495495
496 - global $wgDebugLogFile, $wgOut, $wgShowDebug;
 496+ global $wgDebugLogFile, $wgOut, $wgShowDebug, $wgDebugTimestamps;
497497
498498 $old_log_file = $wgDebugLogFile;
499499 $wgDebugLogFile = tempnam( wfTempDir(), 'mw-' );
 500+ $wgDebugTimestamps = false; # FIXME: this setting should be tested
500501
501502
502503

Status & tagging log