r82515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82514‎ | r82515 | r82516 >
Date:16:50, 20 February 2011
Author:ialex
Status:deferred
Tags:
Comment:
Use Title::getLocalURL() with all parameters instead of WebRequest::appendQueryValue()
Modified paths:
  • /trunk/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfigureWMF/ConfigureWMF.page.php
@@ -109,7 +109,7 @@
110110 $wgOut->addHTML( "<ul>\n" );
111111 $groups = $wgConfigure->getGroupPermissions( $wiki );
112112 foreach( array_keys( $groups ) as $group ) {
113 - $url = htmlspecialchars( $wgRequest->appendQueryValue( 'group', $group ) );
 113+ $url = htmlspecialchars( $this->getTitle()->getLocalURL( "wiki={$wiki}&config={$config}&group={$group}" ) );
114114 $wgOut->addHTML( "<li><a href=\"{$url}\">{$group}</a></li>\n" );
115115 }
116116 $wgOut->addHTML( "</ul></fieldset>\n" );

Status & tagging log