r82495 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82494‎ | r82495 | r82496 >
Date:22:44, 19 February 2011
Author:krinkle
Status:ok
Tags:
Comment:
(bug 3112) Adding colors for active and visited external links.
This is in-core for internal links and red links, but there's no visual clue of active and visited links for external links.

Normal external: #36b;
/* Added: */
Active external: #b63;
Visited external: #636;

These two colors (orange and purple -ish) are in the same saturation/brightness as the blue for normal (inactive/unvisited) external links.
Since these visual clues were also lacking in external links to interwikis I've replaced that override with similar colors as well.
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -552,15 +552,33 @@
553553 background: url("document.png") center right no-repeat;
554554 padding-right: 12px;
555555 }
556 -
557 -/* disable interwiki styling */
 556+
 557+/* Interwiki Styling */
558558 #bodyContent a.extiw,
559559 #bodyContent a.extiw:active {
560560 color: #36b;
 561+ /* Don't show icons for interwiki links */
 562+ background: none;
 563+ padding: 0;
561564 }
 565+#bodyContent a.extiw:visited {
 566+ color: #636;
 567+}
 568+#bodyContent a.extiw:active {
 569+ color: #b63;
 570+}
 571+
 572+/* External links */
562573 #bodyContent a.external {
563574 color: #36b;
564575 }
 576+#bodyContent a.external:visited {
 577+ color: #636; /* bug 3112 */
 578+}
 579+#bodyContent a.external:active {
 580+ color: #b63;
 581+}
 582+
565583 /*
566584 ** Structural Elements
567585 */
Index: trunk/phase3/skins/vector/screen.css
@@ -1108,16 +1108,34 @@
11091109 background: url("images/document-icon.png?2") center right no-repeat;
11101110 padding-right: 13px;
11111111 }
1112 -/* Interwiki Styling (Disabled) */
 1112+
 1113+/* Interwiki Styling */
11131114 div#content a.extiw,
11141115 div#content a.extiw:active {
11151116 color: #36b;
 1117+ /* Don't show icons for interwiki links */
11161118 background: none;
11171119 padding: 0;
11181120 }
 1121+div#content a.extiw:visited {
 1122+ color: #636;
 1123+}
 1124+div#content a.extiw:active {
 1125+ color: #b63;
 1126+}
 1127+
 1128+/* External links */
11191129 div#content a.external {
11201130 color: #36b;
11211131 }
 1132+div#content a.external:visited {
 1133+ color: #636; /* bug 3112 */
 1134+}
 1135+div#content a.external:active {
 1136+ color: #b63;
 1137+}
 1138+
 1139+
11221140 div#content .printfooter {
11231141 display: none;
11241142 }

Sign-offs

UserFlagDate
Lcawteinspected21:41, 28 February 2011

Status & tagging log