r82430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82429‎ | r82430 | r82431 >
Date:00:31, 19 February 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r82428
Modified paths:
  • /trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php (modified) (history)
  • /trunk/extensions/ApprovedRevs/ApprovedRevs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ApprovedRevs/ApprovedRevs.i18n.php
@@ -42,6 +42,7 @@
4343 'approvedrevs-approvelatest' => 'approve latest',
4444 'approvedrevs-approvethisrev' => 'Approve this revision',
4545 'approvedrevs-viewlatestrev' => 'View the latest revision',
 46+ 'approvedrevs-noapprovedrevs' => 'No revision has been approved for this page.',
4647 'right-approverevisions' => 'Set a certain revision of a wiki page as approved',
4748 'right-viewlinktolatest' => 'View explanatory text at the top of pages that have an approved revision',
4849 );
Index: trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php
@@ -561,14 +561,17 @@
562562
563563 if ( empty( $approvedId ) || $approvedId != $article->getRevIdFetched() ) {
564564 if ( $egApprovedRevsBlankIfUnapproved && !$wgRequest->getCheck( 'oldid' ) ) {
565 - $wgOut->addHTML( Xml::element( 'a',
566 - array( 'href' => $article->getTitle()->getLocalUrl(
567 - array(
568 - 'oldid' => $article->getRevIdFetched()
569 - )
570 - ) ),
571 - wfMsg( 'approvedrevs-viewlatestrev' )
572 - ) );
 565+ $wgOut->addHTML(
 566+ htmlspecialchars( wfMsg( 'approvedrevs-noapprovedrevs' ) ) . ' ' .
 567+ Xml::element( 'a',
 568+ array( 'href' => $article->getTitle()->getLocalUrl(
 569+ array(
 570+ 'oldid' => $article->getRevIdFetched()
 571+ )
 572+ ) ),
 573+ wfMsg( 'approvedrevs-viewlatestrev' )
 574+ ) . '.'
 575+ );
573576 }
574577 else {
575578 $wgOut->addHTML( '<b>' . Xml::element( 'a',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82428Added some stuff to improve workflowjeroendedauw00:18, 19 February 2011

Status & tagging log