r82426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82425‎ | r82426 | r82427 >
Date:23:44, 18 February 2011
Author:platonides
Status:ok
Tags:brion 
Comment:
Follow up r63584. The change of resetArticleID() could have all kinds of
side effects, given that it stops lazy cache fillings.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1754,7 +1754,7 @@
17551755
17561756 if ( $affected ) {
17571757 $newid = $dbw->insertId();
1758 - $this->mTitle->resetArticleId( $newid );
 1758+ $this->mTitle->resetArticleID( $newid );
17591759 }
17601760 wfProfileOut( __METHOD__ );
17611761
@@ -2271,6 +2271,8 @@
22722272 $revisionId = $revision->insertOn( $dbw );
22732273
22742274 $this->mTitle->resetArticleID( $newid );
 2275+ # Update the LinkCache. Resetting the Title ArticleID means it will rely on having that already cached (FIXME?)
 2276+ LinkCache::singleton()->addGoodLinkObj( $newid, $this->mTitle, strlen( $text ), (bool)Title::newFromRedirect( $text ), $revisionId );
22752277
22762278 # Update the page record with revision data
22772279 $this->updateRevisionOn( $dbw, $revision, 0 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63584Made resetArticleID() reset redirect/length/latest ID fieldsaaron05:32, 11 March 2010

Status & tagging log