r82349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82348‎ | r82349 | r82350 >
Date:21:34, 17 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Comment out noConflict calls in LQT, it breaks stuff
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/LiquidThreads/jquery/plugins.js (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/LiquidThreads_alpha/jquery/plugins.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/LiquidThreads/jquery/plugins.js
——@@ -3773,7 +3773,7 @@
37743774 /**
37753775 * Mimics the no-conflict method used by the js2 stuff
37763776 */
3777 -$j = jQuery.noConflict();
 3777+//$j = jQuery.noConflict(); // Breaks stuff --catrope
37783778 /**
37793779 * Provides js2 compatible onload hook
37803780 * @param func Function to call when ready
Index: branches/wmf/1.17wmf1/extensions/LiquidThreads_alpha/jquery/plugins.js
——@@ -3773,7 +3773,7 @@
37743774 /**
37753775 * Mimics the no-conflict method used by the js2 stuff
37763776 */
3777 -$j = jQuery.noConflict();
 3777+//$j = jQuery.noConflict(); // Breaks stuff --catrope
37783778 /**
37793779 * Provides js2 compatible onload hook
37803780 * @param func Function to call when ready

Status & tagging log