r82287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82286‎ | r82287 | r82288 >
Date:20:06, 16 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Fixing timestamp bug for users with spaces in their name. Already fixed in trunk with r81692. Pointed out by pawelx on IRC.
Modified paths:
  • /branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoaderWikiModule.php
@@ -108,7 +108,7 @@
109109
110110 $titles = array();
111111 foreach ( $this->getPages( $context ) as $page => $options ) {
112 - $titles[$options['ns']][$page] = true;
 112+ $titles[$options['ns']][str_replace( ' ', '_', $page)] = true;
113113 }
114114
115115 $modifiedTime = 1; // wfTimestamp() interprets 0 as "now"

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81692Fixes for ResourceLoaderWikiModule r72776. No serious bugs found, do not merg...tstarling06:34, 8 February 2011

Status & tagging log