r82256 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82255‎ | r82256 | r82257 >
Date:16:36, 16 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Partial MFT of r82246 (Language.php only)
Modified paths:
  • /branches/wmf/1.17wmf1/languages/Language.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/languages/Language.php
@@ -1561,21 +1561,11 @@
15621562 }
15631563
15641564 function getMessage( $key ) {
1565 - // Don't change getPreferredVariant() to getCode() / mCode, because:
1566 -
1567 - // 1. Some language like Chinese has multiple variant languages. Only
1568 - // getPreferredVariant() (in LanguageConverter) could return a
1569 - // sub-language which would be more suitable for the user.
1570 - // 2. To languages without multiple variants, getPreferredVariant()
1571 - // (in FakeConverter) functions exactly same as getCode() / mCode,
1572 - // it won't break anything.
1573 -
1574 - // The same below.
1575 - return self::$dataCache->getSubitem( $this->getPreferredVariant(), 'messages', $key );
 1565+ return self::$dataCache->getSubitem( $this->mCode, 'messages', $key );
15761566 }
15771567
15781568 function getAllMessages() {
1579 - return self::$dataCache->getItem( $this->getPreferredVariant(), 'messages' );
 1569+ return self::$dataCache->getItem( $this->mCode, 'messages' );
15801570 }
15811571
15821572 function iconv( $in, $out, $string ) {
Property changes on: branches/wmf/1.17wmf1/languages/Language.php
___________________________________________________________________
Modified: svn:mergeinfo
15831573 Merged /trunk/phase3/languages/Language.php:r82246

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82246Follow r77452, r80492. Avoid to find sub-languages when load css/js messages.philip14:18, 16 February 2011

Status & tagging log