r82254 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82253‎ | r82254 | r82255 >
Date:16:25, 16 February 2011
Author:platonides
Status:ok
Tags:
Comment:
Folow up r82046. Fix another leak.
If use_copy then line_copy has got a string from the original NULL, and thus needs being freed.
Modified paths:
  • /trunk/php/wmerrors/wmerrors.c (modified) (history)

Diff [purge]

Index: trunk/php/wmerrors/wmerrors.c
——@@ -207,6 +207,7 @@
208208 smart_str_appendc(s, ' ');
209209
210210 efree(basename);
 211+ zval_dtor(line_copy);
211212 FREE_ZVAL(line_copy);
212213 zend_hash_move_forward_ex(Z_ARRVAL_P(trace), &pos);
213214 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82046wmerrors: Use a dirty hack to add concise backtraces (formatted as Foo.php:12...catrope00:35, 13 February 2011

Status & tagging log