r82140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82139‎ | r82140 | r82141 >
Date:20:32, 14 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Check in live fix for jQuery.client, which was throwing JS errors in certain cases
Modified paths:
  • /branches/wmf/1.17wmf1/resources/jquery/jquery.client.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/resources/jquery/jquery.client.js
@@ -6,7 +6,7 @@
77
88 /* Private Members */
99
10 - var profile;
 10+ var profile, that=this;
1111
1212 /* Public Functions */
1313
@@ -167,7 +167,7 @@
168168 * @return Boolean true if browser known or assumed to be supported, false if blacklisted
169169 */
170170 this.test = function( map ) {
171 - var profile = jQuery.client.profile();
 171+ var profile = that.profile();
172172 var dir = jQuery( 'body' ).is( '.rtl' ) ? 'rtl' : 'ltr';
173173 // Check over each browser condition to determine if we are running in a compatible client
174174 if ( typeof map[dir] !== 'object' || typeof map[dir][profile.name] === 'undefined' ) {

Status & tagging log