r82138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82137‎ | r82138 | r82139 >
Date:20:23, 14 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Patch up LiquidThreads (which was copied from 1.16wmf4) a bit so it'll work with ResourceLoader. These changes don't need merging to trunk because LQT has been RL-ified in trunk already.
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/LiquidThreads/classes/View.php
@@ -1209,7 +1209,7 @@
12101210 $wgOut->addExtensionStyle( "$wgLiquidThreadsExtensionPath/lqt.css?{$wgStyleVersion}" );
12111211
12121212 # Hack to make old LQT work with new WikiEditor, hopefully --catrope
1213 - $wgOut->addModules( array( 'ext.wikiEditor', 'ext.wikiEditor.toolbar.i18n', 'jquery.wikiEditor.toolbar', 'jquery.async', 'jquery.cookie', 'jquery.ui.dialog' ) );
 1213+ $wgOut->addModules( array( 'ext.wikiEditor', 'ext.wikiEditor.toolbar.i18n', 'jquery.wikiEditor.toolbar', 'jquery.wikiEditor.dialogs', 'jquery.async', 'jquery.cookie', 'jquery.ui.dialog' ) );
12141214
12151215 self::$stylesAndScriptsDone = true;
12161216 }
Index: branches/wmf/1.17wmf1/extensions/LiquidThreads/lqt.js
@@ -172,7 +172,8 @@
173173 $j(container).find('#wpDiff').hide();
174174
175175 if ( $j.fn.wikiEditor && $j.wikiEditor.isSupported( $j.wikiEditor.modules.toolbar ) ) {
176 - if ( wgWikiEditorPreferences.toolbar.dialogs && $j.wikiEditor.isSupported( $j.wikiEditor.modules.dialogs ) ) {
 176+ // Dirty hack: use mw.user.options instead of wgWikiEditorPreferences until I think of something better --catrope
 177+ if ( mediaWiki.user.options.get( 'usebetatoolbar-cgd' ) && $j.wikiEditor.isSupported( $j.wikiEditor.modules.dialogs ) ) {
177178 $j( '#wpTextbox1' ).addClass( 'toolbar-dialogs' );
178179 }
179180 // Add wikiEditor toolbar

Status & tagging log