r82113 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82112‎ | r82113 | r82114 >
Date:14:09, 14 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Explicitally define $domain

Documentation
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -89,6 +89,7 @@
9090 // Check if this domain or any superdomain is listed in $wgConf as a local virtual host
9191 $domainParts = array_reverse( $domainParts );
9292
 93+ $domain = '';
9394 for ( $i = 0; $i < count( $domainParts ); $i++ ) {
9495 $domainPart = $domainParts[$i];
9596 if ( $i == 0 ) {
@@ -198,6 +199,8 @@
199200
200201 /**
201202 * Generate a new request object
 203+ * @param $url String: url to use
 204+ * @param $options Array: (optional) extra params to pass (see Http::request())
202205 * @see MWHttpRequest::__construct
203206 */
204207 public static function factory( $url, $options = null ) {

Sign-offs

UserFlagDate
Bryaninspected14:45, 14 February 2011 (struck 14:45, 14 February 2011)

Status & tagging log