r82010 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82009‎ | r82010 | r82011 >
Date:09:49, 12 February 2011
Author:aaron
Status:ok
Tags:
Comment:
* Removed the last mediawiki.legacy dependencies
* Follow-up r82009: removed reference to bogus var
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/flaggedrevs.js (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/review.js (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -364,7 +364,7 @@
365365 'revreview-log-toggle-show', 'revreview-log-toggle-hide',
366366 'revreview-log-details-show', 'revreview-log-details-hide'
367367 ),
368 - 'dependencies' => array( 'jquery', 'mediawiki.legacy.wikibits' ),
 368+ 'dependencies' => array( 'jquery', 'mediawiki.util' ),
369369 'localBasePath' => $dir,
370370 'remoteExtPath' => 'FlaggedRevs'
371371 );
@@ -377,7 +377,7 @@
378378 'revreview-submit-reviewed', 'revreview-submit-unreviewed',
379379 'revreview-submitting', 'actioncomplete', 'actionfailed'
380380 ),
381 - 'dependencies' => array( 'jquery' ),
 381+ 'dependencies' => array( 'jquery', 'mediawiki.util' ),
382382 'localBasePath' => $dir,
383383 'remoteExtPath' => 'FlaggedRevs'
384384 );
Index: trunk/extensions/FlaggedRevs/client/flaggedrevs.js
@@ -174,7 +174,7 @@
175175 + ' [' + mediaWiki.msg('accesskey-save') + ']';
176176 }
177177 }
178 - window.updateTooltipAccessKeys( [ save ] ); // update accesskey in save.title
 178+ mediaWiki.util.updateTooltipAccessKeys( [ save ] ); // update accesskey in save.title
179179 }
180180 };
181181
Index: trunk/extensions/FlaggedRevs/client/review.js
@@ -295,9 +295,9 @@
296296 }
297297 // (b) Output any error response message
298298 if( response.indexOf('<err#>') == 0 ) {
299 - jsMsg( msg, 'review' ); // failure notice
 299+ mediaWiki.util.jsMessage( msg, 'review' ); // failure notice
300300 } else {
301 - jsMsg( request.responseText, 'review' ); // fatal notice
 301+ mediaWiki.util.jsMessage( response, 'review' ); // fatal notice
302302 }
303303 window.scroll(0,0); // scroll up to notice
304304 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82009Refactored AJAX review code in review.js and removed mediawiki.legacy.ajax de...aaron09:33, 12 February 2011

Status & tagging log