r81990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81989‎ | r81990 | r81991 >
Date:19:52, 11 February 2011
Author:laner
Status:deferred
Tags:
Comment:
Adding 'name' field to all html parameters to have compatibility with 1.17
Modified paths:
  • /trunk/extensions/OpenStackManager/special/SpecialNovaAddress.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaKey.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaProject.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaRole.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaSecurityGroup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php
@@ -86,6 +86,7 @@
8787 'validation-callback' => array( $this, 'validateInstanceName' ),
8888 'default' => '',
8989 'section' => 'instance/info',
 90+ 'name' => 'instancename',
9091 );
9192
9293 $instanceTypes = $this->adminNova->getInstanceTypes();
@@ -103,6 +104,7 @@
104105 'label-message' => 'openstackmanager-instancetype',
105106 'section' => 'instance/info',
106107 'options' => $instanceType_keys,
 108+ 'name' => 'instanceType',
107109 );
108110
109111 # Availability zone names can't be translated. Get the keys, and make an array
@@ -117,6 +119,7 @@
118120 'section' => 'instance/info',
119121 'options' => $availabilityZone_keys,
120122 'label-message' => 'openstackmanager-availabilityzone',
 123+ 'name' => 'availabilityZone',
121124 );
122125
123126 # Image names can't be translated. Get the image, and make an array
@@ -145,6 +148,7 @@
146149 'section' => 'instance/info',
147150 'options' => $image_keys,
148151 'label-message' => 'openstackmanager-imagetype',
 152+ 'name' => 'imageType',
149153 );
150154
151155 # Keypair names can't be translated. Get the keys, and make an array
@@ -173,6 +177,7 @@
174178 'section' => 'instance/info',
175179 'options' => $domain_keys,
176180 'label-message' => 'openstackmanager-dnsdomain',
 181+ 'name' => 'domain',
177182 );
178183
179184 $securityGroups = $this->adminNova->getSecurityGroups();
@@ -188,11 +193,13 @@
189194 'section' => 'instance/info',
190195 'options' => $group_keys,
191196 'label-message' => 'openstackmanager-securitygroups',
 197+ 'name' => 'groups',
192198 );
193199
194200 $instanceInfo['project'] = array(
195201 'type' => 'hidden',
196202 'default' => $project,
 203+ 'name' => 'project',
197204 );
198205
199206 if ( $wgOpenStackManagerPuppetOptions['enabled'] ) {
@@ -206,6 +213,7 @@
207214 'section' => 'instance/puppetinfo',
208215 'options' => $classes,
209216 'label-message' => 'openstackmanager-puppetclasses',
 217+ 'name' => 'puppetclasses',
210218 );
211219 }
212220
@@ -215,6 +223,7 @@
216224 'type' => 'text',
217225 'section' => 'instance/puppetinfo',
218226 'label' => $variable,
 227+ 'name' => "$variable",
219228 );
220229 }
221230 }
@@ -223,6 +232,7 @@
224233 $instanceInfo['action'] = array(
225234 'type' => 'hidden',
226235 'default' => 'create',
 236+ 'name' => 'action',
227237 );
228238
229239 $instanceForm = new SpecialNovaInstanceForm( $instanceInfo, 'openstackmanager-novainstance' );
@@ -231,6 +241,7 @@
232242 $instanceForm->setSubmitCallback( array( $this, 'tryCreateSubmit' ) );
233243 $instanceForm->show();
234244
 245+ return true;
235246 }
236247
237248 /**
@@ -253,10 +264,12 @@
254265 $instanceInfo['instanceid'] = array(
255266 'type' => 'hidden',
256267 'default' => $instanceid,
 268+ 'name' => 'instanceid',
257269 );
258270 $instanceInfo['project'] = array(
259271 'type' => 'hidden',
260272 'default' => $project,
 273+ 'name' => 'project',
261274 );
262275
263276 if ( $wgOpenStackManagerPuppetOptions['enabled'] ) {
@@ -282,6 +295,7 @@
283296 'options' => $classes,
284297 'default' => $defaults,
285298 'label-message' => 'openstackmanager-puppetclasses',
 299+ 'name' => 'puppetclasses',
286300 );
287301 }
288302
@@ -296,6 +310,7 @@
297311 'section' => 'instance/puppetinfo',
298312 'label' => $variable,
299313 'default' => $default,
 314+ 'name' => "$variable",
300315 );
301316 }
302317 }
@@ -304,6 +319,7 @@
305320 $instanceInfo['action'] = array(
306321 'type' => 'hidden',
307322 'default' => 'configure',
 323+ 'name' => 'action',
308324 );
309325
310326 $instanceForm = new SpecialNovaInstanceForm( $instanceInfo, 'openstackmanager-novainstance' );
@@ -337,14 +353,17 @@
338354 $instanceInfo['instanceid'] = array(
339355 'type' => 'hidden',
340356 'default' => $instanceid,
 357+ 'name' => 'instanceid',
341358 );
342359 $instanceInfo['project'] = array(
343360 'type' => 'hidden',
344361 'default' => $project,
 362+ 'name' => 'project',
345363 );
346364 $instanceInfo['action'] = array(
347365 'type' => 'hidden',
348366 'default' => 'delete',
 367+ 'name' => 'action',
349368 );
350369 $instanceForm = new SpecialNovaInstanceForm( $instanceInfo, 'openstackmanager-novainstance' );
351370 $instanceForm->setTitle( SpecialPage::getTitleFor( 'NovaInstance' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaSecurityGroup.php
@@ -62,20 +62,24 @@
6363 'type' => 'text',
6464 'label-message' => 'openstackmanager-securitygroupname',
6565 'default' => '',
 66+ 'name' => 'groupname',
6667 );
6768 $securityGroupInfo['description'] = array(
6869 'type' => 'text',
6970 'label-message' => 'openstackmanager-securitygroupdescription',
7071 'default' => '',
 72+ 'name' => 'description',
7173 );
7274 $securityGroupInfo['project'] = array(
7375 'type' => 'hidden',
7476 'default' => $project,
 77+ 'name' => 'project',
7578 );
7679
7780 $securityGroupInfo['action'] = array(
7881 'type' => 'hidden',
7982 'default' => 'create',
 83+ 'name' => 'action',
8084 );
8185
8286 $securityGroupForm = new SpecialNovaSecurityGroupForm( $securityGroupInfo, 'openstackmanager-novasecuritygroup' );
@@ -110,20 +114,24 @@
111115 $securityGroupInfo['groupname'] = array(
112116 'type' => 'hidden',
113117 'default' => $securitygroupname,
 118+ 'name' => 'groupname',
114119 );
115120 $securityGroupInfo['description'] = array(
116121 'type' => 'text',
117122 'label-message' => 'openstackmanager-securitygroupdescription',
118123 'default' => $description,
 124+ 'name' => 'description',
119125 );
120126 $securityGroupInfo['project'] = array(
121127 'type' => 'hidden',
122128 'default' => $project,
 129+ 'name' => 'project',
123130 );
124131
125132 $securityGroupInfo['action'] = array(
126133 'type' => 'hidden',
127134 'default' => 'configure',
 135+ 'name' => 'action',
128136 );
129137
130138 $securityGroupForm = new SpecialNovaSecurityGroupForm( $securityGroupInfo, 'openstackmanager-novasecuritygroup' );
@@ -158,14 +166,17 @@
159167 $securityGroupInfo['groupname'] = array(
160168 'type' => 'hidden',
161169 'default' => $securitygroupname,
 170+ 'name' => 'groupname',
162171 );
163172 $securityGroupInfo['project'] = array(
164173 'type' => 'hidden',
165174 'default' => $project,
 175+ 'name' => 'project',
166176 );
167177 $securityGroupInfo['action'] = array(
168178 'type' => 'hidden',
169179 'default' => 'delete',
 180+ 'name' => 'action',
170181 );
171182 $securityGroupForm = new SpecialNovaSecurityGroupForm( $securityGroupInfo, 'openstackmanager-novasecuritygroup' );
172183 $securityGroupForm->setTitle( SpecialPage::getTitleFor( 'NovaSecurityGroup' ) );
@@ -332,41 +343,49 @@
333344 $securityGroupInfo['groupname'] = array(
334345 'type' => 'hidden',
335346 'default' => $securitygroupname,
 347+ 'name' => 'groupname',
336348 );
337349 $securityGroupInfo['project'] = array(
338350 'type' => 'hidden',
339351 'default' => $project,
 352+ 'name' => 'project',
340353 );
341354 $securityGroupInfo['fromport'] = array(
342355 'type' => 'text',
343356 'label-message' => 'openstackmanager-securitygrouprule-fromport',
344357 'default' => '',
 358+ 'name' => 'fromport',
345359 );
346360 $securityGroupInfo['toport'] = array(
347361 'type' => 'text',
348362 'label-message' => 'openstackmanager-securitygrouprule-toport',
349363 'default' => '',
 364+ 'name' => 'toport',
350365 );
351366 $securityGroupInfo['protocol'] = array(
352367 'type' => 'select',
353368 'label-message' => 'openstackmanager-securitygrouprule-protocol',
354369 'options' => array( '' => '', 'icmp' => 'icmp', 'tcp' => 'tcp', 'udp' => 'udp' ),
 370+ 'name' => 'protocol',
355371 );
356372 $securityGroupInfo['ranges'] = array(
357373 'type' => 'text',
358374 'label-message' => 'openstackmanager-securitygrouprule-ranges',
359375 'help-message' => 'openstackmanager-securitygrouprule-ranges-help',
360376 'default' => '',
 377+ 'name' => 'ranges',
361378 );
362379 $securityGroupInfo['groups'] = array(
363380 'type' => 'multiselect',
364381 'label-message' => 'openstackmanager-securitygrouprule-groups',
365382 'help-message' => 'openstackmanager-securitygrouprule-groups-help',
366383 'options' => $group_keys,
 384+ 'name' => 'groups',
367385 );
368386 $securityGroupInfo['action'] = array(
369387 'type' => 'hidden',
370388 'default' => 'addrule',
 389+ 'name' => 'action',
371390 );
372391 $securityGroupForm = new SpecialNovaSecurityGroupForm( $securityGroupInfo, 'openstackmanager-novasecuritygroup' );
373392 $securityGroupForm->setTitle( SpecialPage::getTitleFor( 'NovaSecurityGroup' ) );
@@ -399,38 +418,46 @@
400419 $securityGroupInfo['groupname'] = array(
401420 'type' => 'hidden',
402421 'default' => $securitygroupname,
 422+ 'name' => 'groupname',
403423 );
404424 $securityGroupInfo['project'] = array(
405425 'type' => 'hidden',
406426 'default' => $project,
 427+ 'name' => 'project',
407428 );
408429 $securityGroupInfo['fromport'] = array(
409430 'type' => 'hidden',
410431 'default' => $wgRequest->getText( 'fromport' ),
 432+ 'name' => 'fromport',
411433 );
412434 $securityGroupInfo['toport'] = array(
413435 'type' => 'hidden',
414436 'default' => $wgRequest->getText( 'toport' ),
 437+ 'name' => 'toport',
415438 );
416439 $securityGroupInfo['protocol'] = array(
417440 'type' => 'hidden',
418441 'default' => $wgRequest->getText( 'protocol' ),
 442+ 'name' => 'protocol',
419443 );
420444 if ( $wgRequest->getText( 'ranges' ) ) {
421445 $securityGroupInfo['ranges'] = array(
422446 'type' => 'hidden',
423447 'default' => $wgRequest->getText( 'ranges' ),
 448+ 'name' => 'ranges',
424449 );
425450 }
426451 if ( $wgRequest->getText( 'groups' ) ) {
427452 $securityGroupInfo['groups'] = array(
428453 'type' => 'hidden',
429454 'default' => $wgRequest->getText( 'groups' ),
 455+ 'name' => 'groups',
430456 );
431457 }
432458 $securityGroupInfo['action'] = array(
433459 'type' => 'hidden',
434460 'default' => 'removerule',
 461+ 'name' => 'action',
435462 );
436463 $securityGroupForm = new SpecialNovaSecurityGroupForm( $securityGroupInfo, 'openstackmanager-novasecuritygroup' );
437464 $securityGroupForm->setTitle( SpecialPage::getTitleFor( 'NovaSecurityGroup' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaAddress.php
@@ -67,10 +67,12 @@
6868 $addressInfo['project'] = array(
6969 'type' => 'hidden',
7070 'default' => $project,
 71+ 'name' => 'project',
7172 );
7273 $addressInfo['action'] = array(
7374 'type' => 'hidden',
7475 'default' => 'allocate',
 76+ 'name' => 'action',
7577 );
7678
7779 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
@@ -106,14 +108,17 @@
107109 $addressInfo['project'] = array(
108110 'type' => 'hidden',
109111 'default' => $project,
 112+ 'name' => 'project',
110113 );
111114 $addressInfo['ip'] = array(
112115 'type' => 'hidden',
113116 'default' => $ip,
 117+ 'name' => 'ip',
114118 );
115119 $addressInfo['action'] = array(
116120 'type' => 'hidden',
117121 'default' => 'release',
 122+ 'name' => 'action',
118123 );
119124 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
120125 $addressForm->setTitle( SpecialPage::getTitleFor( 'NovaAddress' ) );
@@ -155,19 +160,23 @@
156161 $addressInfo['project'] = array(
157162 'type' => 'hidden',
158163 'default' => $project,
 164+ 'name' => 'project',
159165 );
160166 $addressInfo['ip'] = array(
161167 'type' => 'hidden',
162168 'default' => $ip,
 169+ 'name' => 'ip',
163170 );
164171 $addressInfo['instanceid'] = array(
165172 'type' => 'select',
166173 'label-message' => 'openstackmanager-instancename',
167174 'options' => $instance_keys,
 175+ 'name' => 'instanceid',
168176 );
169177 $addressInfo['action'] = array(
170178 'type' => 'hidden',
171179 'default' => 'associate',
 180+ 'name' => 'action',
172181 );
173182 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
174183 $addressForm->setTitle( SpecialPage::getTitleFor( 'NovaAddress' ) );
@@ -202,14 +211,17 @@
203212 $addressInfo['project'] = array(
204213 'type' => 'hidden',
205214 'default' => $project,
 215+ 'name' => 'project',
206216 );
207217 $addressInfo['ip'] = array(
208218 'type' => 'hidden',
209219 'default' => $ip,
 220+ 'name' => 'ip',
210221 );
211222 $addressInfo['action'] = array(
212223 'type' => 'hidden',
213224 'default' => 'disassociate',
 225+ 'name' => 'action',
214226 );
215227 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
216228 $addressForm->setTitle( SpecialPage::getTitleFor( 'NovaAddress' ) );
@@ -240,16 +252,19 @@
241253 $addressInfo['project'] = array(
242254 'type' => 'hidden',
243255 'default' => $project,
 256+ 'name' => 'project',
244257 );
245258 $addressInfo['ip'] = array(
246259 'type' => 'hidden',
247260 'default' => $ip,
 261+ 'name' => 'ip',
248262 );
249263 $addressInfo['hostname'] = array(
250264 'type' => 'text',
251265 'default' => '',
252266 'validation-callback' => array( $this, 'validateHostName' ),
253267 'label-message' => 'openstackmanager-hostname',
 268+ 'name' => 'hostname',
254269 );
255270 $domains = OpenStackNovaDomain::getAllDomains( 'public' );
256271 $domain_keys = array();
@@ -261,10 +276,12 @@
262277 'type' => 'select',
263278 'options' => $domain_keys,
264279 'label-message' => 'openstackmanager-dnsdomain',
 280+ 'name' => 'domain',
265281 );
266282 $addressInfo['action'] = array(
267283 'type' => 'hidden',
268284 'default' => 'addhost',
 285+ 'name' => 'action',
269286 );
270287 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
271288 $addressForm->setTitle( SpecialPage::getTitleFor( 'NovaAddress' ) );
@@ -301,22 +318,27 @@
302319 $addressInfo['project'] = array(
303320 'type' => 'hidden',
304321 'default' => $project,
 322+ 'name' => 'project',
305323 );
306324 $addressInfo['ip'] = array(
307325 'type' => 'hidden',
308326 'default' => $ip,
 327+ 'name' => 'ip',
309328 );
310329 $addressInfo['domain'] = array(
311330 'type' => 'hidden',
312331 'default' => $domain,
 332+ 'name' => 'domain',
313333 );
314334 $addressInfo['hostname'] = array(
315335 'type' => 'hidden',
316336 'default' => $hostname,
 337+ 'name' => 'hostname',
317338 );
318339 $addressInfo['action'] = array(
319340 'type' => 'hidden',
320341 'default' => 'removehost',
 342+ 'name' => 'action',
321343 );
322344 $addressForm = new SpecialNovaAddressForm( $addressInfo, 'openstackmanager-novaaddress' );
323345 $addressForm->setTitle( SpecialPage::getTitleFor( 'NovaAddress' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaProject.php
@@ -57,11 +57,13 @@
5858 'validation-callback' => array( $this, 'validateProjectName' ),
5959 'default' => '',
6060 'section' => 'project/info',
 61+ 'name' => 'projectname',
6162 );
6263
6364 $projectInfo['action'] = array(
6465 'type' => 'hidden',
6566 'default' => 'create',
 67+ 'name' => 'action',
6668 );
6769
6870 $projectForm = new SpecialNovaProjectForm( $projectInfo, 'openstackmanager-novaproject' );
@@ -94,14 +96,17 @@
9597 'label-message' => 'openstackmanager-member',
9698 'default' => '',
9799 'section' => 'project/info',
 100+ 'name' => 'member',
98101 );
99102 $projectInfo['action'] = array(
100103 'type' => 'hidden',
101104 'default' => 'addmember',
 105+ 'name' => 'action',
102106 );
103107 $projectInfo['projectname'] = array(
104108 'type' => 'hidden',
105109 'default' => $project,
 110+ 'name' => 'projectname',
106111 );
107112
108113 $projectForm = new SpecialNovaProjectForm( $projectInfo, 'openstackmanager-novaproject' );
@@ -140,14 +145,17 @@
141146 'label-message' => 'openstackmanager-member',
142147 'section' => 'project/info',
143148 'options' => $member_keys,
 149+ 'name' => 'members',
144150 );
145151 $projectInfo['action'] = array(
146152 'type' => 'hidden',
147153 'default' => 'deletemember',
 154+ 'name' => 'action',
148155 );
149156 $projectInfo['projectname'] = array(
150157 'type' => 'hidden',
151158 'default' => $projectname,
 159+ 'name' => 'projectname',
152160 );
153161
154162 $projectForm = new SpecialNovaProjectForm( $projectInfo, 'openstackmanager-novaproject' );
@@ -181,10 +189,12 @@
182190 $projectInfo['projectname'] = array(
183191 'type' => 'hidden',
184192 'default' => $project,
 193+ 'name' => 'projectname',
185194 );
186195 $projectInfo['action'] = array(
187196 'type' => 'hidden',
188197 'default' => 'delete',
 198+ 'name' => 'action',
189199 );
190200 $projectForm = new SpecialNovaProjectForm( $projectInfo, 'openstackmanager-novaproject' );
191201 $projectForm->setTitle( SpecialPage::getTitleFor( 'NovaProject' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php
@@ -67,12 +67,14 @@
6868 'label-message' => 'openstackmanager-domainname',
6969 'default' => '',
7070 'section' => 'domain/info',
 71+ 'name' => 'domainname',
7172 );
7273 $domainInfo['fqdn'] = array(
7374 'type' => 'text',
7475 'label-message' => 'openstackmanager-fqdn',
7576 'default' => '',
7677 'section' => 'domain/info',
 78+ 'name' => 'fqdn',
7779 );
7880 $domainInfo['location'] = array(
7981 'type' => 'text',
@@ -80,10 +82,12 @@
8183 'default' => '',
8284 'section' => 'domain/info',
8385 'help-message' => 'openstackmanager-location-help',
 86+ 'name' => 'location',
8487 );
8588 $domainInfo['action'] = array(
8689 'type' => 'hidden',
8790 'default' => 'create',
 91+ 'name' => 'action',
8892 );
8993
9094 $domainForm = new SpecialNovaDomainForm( $domainInfo, 'openstackmanager-novadomain' );
@@ -112,10 +116,12 @@
113117 $domainInfo['domainname'] = array(
114118 'type' => 'hidden',
115119 'default' => $domainname,
 120+ 'name' => 'domainname',
116121 );
117122 $domainInfo['action'] = array(
118123 'type' => 'hidden',
119124 'default' => 'delete',
 125+ 'name' => 'action',
120126 );
121127 $domainForm = new SpecialNovaDomainForm( $domainInfo, 'openstackmanager-novadomain' );
122128 $domainForm->setTitle( SpecialPage::getTitleFor( 'NovaDomain' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaKey.php
@@ -59,6 +59,7 @@
6060 'label-message' => 'openstackmanager-novakeyname',
6161 'default' => '',
6262 'section' => 'key/info',
 63+ 'name' => 'keyname',
6364 );
6465 }
6566
@@ -67,16 +68,19 @@
6869 'section' => 'key/info',
6970 'default' => '',
7071 'label-message' => 'openstackmanager-novapublickey',
 72+ 'name' => 'key',
7173 );
7274
7375 $keyInfo['action'] = array(
7476 'type' => 'hidden',
7577 'default' => 'import',
 78+ 'name' => 'action',
7679 );
7780
7881 $keyInfo['project'] = array(
7982 'type' => 'hidden',
8083 'default' => htmlentities( $project ),
 84+ 'name' => 'project',
8185 );
8286
8387 $keyForm = new SpecialNovaKeyForm( $keyInfo, 'openstackmanager-novakey' );
@@ -111,10 +115,12 @@
112116 $keyInfo['keyname'] = array(
113117 'type' => 'hidden',
114118 'default' => $project,
 119+ 'name' => 'keyname',
115120 );
116121 $keyInfo['project'] = array(
117122 'type' => 'hidden',
118123 'default' => $keyname,
 124+ 'name' => 'project',
119125 );
120126 } else if ( $wgOpenStackManagerNovaKeypairStorage == 'ldap' ) {
121127 $hash = $wgRequest->getVal( 'hash' );
@@ -126,15 +132,18 @@
127133 $keyInfo['hash'] = array(
128134 'type' => 'hidden',
129135 'default' => $hash,
 136+ 'name' => 'hash',
130137 );
131138 }
132139 $keyInfo['key'] = array(
133140 'type' => 'hidden',
134141 'default' => $keypairs[$hash],
 142+ 'name' => 'key',
135143 );
136144 $keyInfo['action'] = array(
137145 'type' => 'hidden',
138146 'default' => 'delete',
 147+ 'name' => 'action',
139148 );
140149 $keyForm = new SpecialNovaKeyForm( $keyInfo, 'openstackmanager-novakey' );
141150 $keyForm->setTitle( SpecialPage::getTitleFor( 'NovaKey' ) );
Index: trunk/extensions/OpenStackManager/special/SpecialNovaRole.php
@@ -69,6 +69,7 @@
7070 'label-message' => 'openstackmanager-member',
7171 'options' => $member_keys,
7272 'section' => 'role/info',
 73+ 'name' => 'members',
7374 );
7475 } else {
7576 if ( !$this->userCanExecute( $wgUser ) ) {
@@ -80,23 +81,28 @@
8182 'label-message' => 'openstackmanager-member',
8283 'default' => '',
8384 'section' => 'role/info',
 85+ 'name' => 'members',
8486 );
8587 }
8688 $roleInfo['action'] = array(
8789 'type' => 'hidden',
8890 'default' => 'addmember',
 91+ 'name' => 'action',
8992 );
9093 $roleInfo['rolename'] = array(
9194 'type' => 'hidden',
9295 'default' => $rolename,
 96+ 'name' => 'rolename',
9397 );
9498 $roleInfo['projectname'] = array(
9599 'type' => 'hidden',
96100 'default' => $projectname,
 101+ 'name' => 'projectname',
97102 );
98103 $roleInfo['returnto'] = array(
99104 'type' => 'hidden',
100105 'default' => $wgRequest->getText('returnto'),
 106+ 'name' => 'returnto',
101107 );
102108
103109 $roleForm = new SpecialNovaRoleForm( $roleInfo, 'openstackmanager-novarole' );
@@ -157,22 +163,27 @@
158164 'label-message' => 'openstackmanager-member',
159165 'options' => $member_keys,
160166 'section' => 'role/info',
 167+ 'name' => 'members',
161168 );
162169 $roleInfo['action'] = array(
163170 'type' => 'hidden',
164171 'default' => 'deletemember',
 172+ 'name' => 'action',
165173 );
166174 $roleInfo['rolename'] = array(
167175 'type' => 'hidden',
168176 'default' => $rolename,
 177+ 'name' => 'rolename',
169178 );
170179 $roleInfo['projectname'] = array(
171180 'type' => 'hidden',
172181 'default' => $projectname,
 182+ 'name' => 'projectname',
173183 );
174184 $roleInfo['returnto'] = array(
175185 'type' => 'hidden',
176186 'default' => $wgRequest->getText('returnto'),
 187+ 'name' => 'returnto',
177188 );
178189
179190 $roleForm = new SpecialNovaRoleForm( $roleInfo, 'openstackmanager-novarole' );

Status & tagging log