r81925 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81924‎ | r81925 | r81926 >
Date:00:31, 11 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Minor followup to r81865, only set dir to ltr if it's not already set to something else
Modified paths:
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
@@ -99,7 +99,10 @@
100100 if ( $enclose === GESHI_HEADER_NONE ) {
101101 $attribs = self::addAttribute( $attribs, 'class', 'mw-geshi ' . $lang . ' source-' . $lang );
102102 } else {
103 - $attribs = self::addAttribute( $attribs, 'dir', 'ltr' );
 103+ if ( !isset( $attribs['dir'] ) ) {
 104+ $attribs = self::addAttribute( $attribs, 'dir', 'ltr' );
 105+ }
 106+
104107 $attribs = self::addAttribute( $attribs, 'class', 'mw-geshi' );
105108 $attribs = self::addAttribute( $attribs, 'style', 'text-align: left;' );
106109 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81865*(bug 10081) Allow html attribute on SyntaxHighlight GeSHi extension...reedy01:59, 10 February 2011

Status & tagging log