r81870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81869‎ | r81870 | r81871 >
Date:02:42, 10 February 2011
Author:reedy
Status:deferred
Tags:
Comment:
while to foreach

followup r81864
Modified paths:
  • /trunk/extensions/ResearchTools/api/ApiQueryResearchToolsSurveys.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ResearchTools/api/ApiQueryResearchToolsSurveys.php
@@ -40,7 +40,7 @@
4141 __METHOD__
4242 );
4343 $survey['questions'] = array();
44 - while ( $row = $dbr->fetchObject( $questionRows ) ) {
 44+ foreach ( $questionRows as $row ) {
4545 $survey['questions'][] = $row;
4646 }
4747 $result->addValue( array( 'query', $this->getModuleName() ), null, $survey );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81864Added schema changes and API modules for survey system. Now you can...tparscal01:56, 10 February 2011

Status & tagging log