r81840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81839‎ | r81840 | r81841 >
Date:19:32, 9 February 2011
Author:neilk
Status:deferred
Tags:
Comment:
insertBefore should go before html call - confuses some browsers
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -1715,12 +1715,14 @@
17161716 deeds,
17171717 _this.uploads.length );
17181718
1719 - $j( '<div>' ).html( gM( 'mwe-upwiz-deeds-macro-prompt', _this.uploads.length ) )
1720 - .insertBefore ( _this.deedChooser.$selector.find( '.mwe-upwiz-deed-ownwork' ) );
 1719+ $j( '<div>' )
 1720+ .insertBefore( _this.deedChooser.$selector.find( '.mwe-upwiz-deed-ownwork' ) )
 1721+ .html( gM( 'mwe-upwiz-deeds-macro-prompt', _this.uploads.length ) );
17211722
17221723 if ( _this.uploads.length > 1 ) {
1723 - $j( '<div style="margin-top: 1em">' ).html( gM( 'mwe-upwiz-deeds-custom-prompt' ) )
1724 - .insertBefore( _this.deedChooser.$selector.find( '.mwe-upwiz-deed-custom' ) );
 1724+ $j( '<div style="margin-top: 1em">' )
 1725+ .insertBefore( _this.deedChooser.$selector.find( '.mwe-upwiz-deed-custom' ) )
 1726+ .html( gM( 'mwe-upwiz-deeds-custom-prompt' ) );
17251727 }
17261728
17271729 _this.moveToStep( 'deeds' );

Status & tagging log