r81811 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r81810‎ \| r81811 \| r81812 >
Date:	08:59, 9 February 2011
Author:	aaron
Status:	ok
Tags:
Comment:	Replaced ugly "array( 'parseinline' )" param with shorter "'parseline'" param
Modified paths:	/trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history) /trunk/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history) /trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php (modified) (history) /trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php
—	—	@@ -193,12 +193,12 @@
194	194	</tr>';
195	195	# Add comment input and submit button
196	196	if ( $form->isAllowed() ) {
197		~~- $watchLabel = wfMsgExt( 'watchthis', array( 'parseinline' ) );~~
	197	+ $watchLabel = wfMsgExt( 'watchthis', 'parseinline' );
198	198	$watchAttribs = array( 'accesskey' => wfMsg( 'accesskey-watch' ),
199	199	'id' => 'wpWatchthis' );
200	200	$watchChecked = ( $wgUser->getOption( 'watchdefault' )
201	201	\|\| $title->userIsWatching() );
202		~~- $reviewLabel = wfMsgExt( 'stabilization-review', array( 'parseinline' ) );~~
	202	+ $reviewLabel = wfMsgExt( 'stabilization-review', 'parseinline' );
203	203
204	204	$s .= ' <tr>
205	205	<td class="mw-label">' .
Index: trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php
—	—	@@ -82,7 +82,7 @@
83	83	$msgs = array( 'ns', 'total', 'stable', 'latest', 'synced', 'old' ); // our headings
84	84	foreach ( $msgs as $msg ) {
85	85	$wgOut->addHTML( '<th>' .
86		~~- wfMsgExt( "validationstatistics-$msg", array( 'parseinline' ) ) . '</th>' );~~
	86	+ wfMsgExt( "validationstatistics-$msg", 'parseinline' ) . '</th>' );
87	87	}
88	88	$wgOut->addHTML( "</tr>\n" );
89	89	$namespaces = FlaggedRevs::getReviewNamespaces();
Index: trunk/extensions/FlaggedRevs/FlaggedRevsXML.php
—	—	@@ -237,12 +237,12 @@
238	238	if ( $synced && ( $type == 'stable' \|\| $type == 'draft' ) ) {
239	239	$msg = $quality ?
240	240	'revreview-quality-same' : 'revreview-basic-same';
241		~~- $html = wfMsgExt( $msg, array( 'parseinline' ),~~
	241	+ $html = wfMsgExt( $msg, 'parseinline',
242	242	$frev->getRevId(), $time, $revsSince );
243	243	} elseif ( $type == 'oldstable' ) {
244	244	$msg = $quality ?
245	245	'revreview-quality-old' : 'revreview-basic-old';
246		~~- $html = wfMsgExt( $msg, array( 'parseinline' ), $frev->getRevId(), $time );~~
	246	+ $html = wfMsgExt( $msg, 'parseinline', $frev->getRevId(), $time );
247	247	} else {
248	248	if ( $type == 'stable' ) {
249	249	$msg = $quality ?
—	—	@@ -254,7 +254,7 @@
255	255	# For searching: uses messages 'revreview-quality-i', 'revreview-basic-i',
256	256	# 'revreview-newest-quality-i', 'revreview-newest-basic-i'
257	257	$msg .= ( $revsSince == 0 ) ? '-i' : '';
258		~~- $html = wfMsgExt( $msg, array( 'parseinline' ),~~
	258	+ $html = wfMsgExt( $msg, 'parseinline',
259	259	$frev->getRevId(), $time, $revsSince );
260	260	}
261	261	# Make fancy box...
—	—	@@ -404,7 +404,7 @@
405	405	$msg = FlaggedRevs::isQuality( $flags )
406	406	? 'revreview-pending-quality'
407	407	: 'revreview-pending-basic';
408		~~- $tag = wfMsgExt( $msg, array( 'parseinline' ), $frev->getRevId(), $time, $revsSince );~~
	408	+ $tag = wfMsgExt( $msg, 'parseinline', $frev->getRevId(), $time, $revsSince );
409	409	return $tag;
410	410	}
411	411
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
—	—	@@ -242,7 +242,7 @@
243	243	$flags = $frev->getTags();
244	244	$quality = FlaggedRevs::isQuality( $flags );
245	245	$msg = $quality ? 'revreview-quality-source' : 'revreview-basic-source';
246		~~- $tag = wfMsgExt( $msg, array( 'parseinline' ), $frev->getRevId(), $time );~~
	246	+ $tag = wfMsgExt( $msg, 'parseinline', $frev->getRevId(), $time );
247	247	# Hide clutter
248	248	if ( !$this->useSimpleUI() && !empty( $flags ) ) {
249	249	$tag .= FlaggedRevsXML::ratingToggle() .
—	—	@@ -403,14 +403,14 @@
404	404	if ( $this->useSimpleUI() ) {
405	405	// RTL langauges
406	406	$rtl = $wgContLang->isRTL() ? " rtl" : "";
407		~~- $tag .= $prot . $icon . wfMsgExt( 'revreview-quick-none', array( 'parseinline' ) );~~
	407	+ $tag .= $prot . $icon . wfMsgExt( 'revreview-quick-none', 'parseinline' );
408	408	$css = "flaggedrevs_short{$rtl} plainlinks noprint";
409	409	$this->reviewNotice .= "<div id='mw-fr-revisiontag' class='$css'>$tag</div>";
410	410	// Standard UI
411	411	} else {
412	412	$css = 'flaggedrevs_notice plainlinks noprint';
413	413	$tag = "<div id='mw-fr-revisiontag' class='$css'>" .
414		~~- $prot . $icon . wfMsgExt( 'revreview-noflagged', array( 'parseinline' ) ) .~~
	414	+ $prot . $icon . wfMsgExt( 'revreview-noflagged', 'parseinline' ) .
415	415	"</div>";
416	416	$this->reviewNotice .= $tag;
417	417	}
—	—	@@ -454,7 +454,7 @@
455	455	$pending .= FlaggedRevsXML::draftStatusIcon();
456	456	}
457	457	$pending .= wfMsgExt( 'revreview-edited',
458		~~- array( 'parseinline' ), $srev->getRevId(), $revsSince );~~
	458	+ 'parseinline', $srev->getRevId(), $revsSince );
459	459	$anchor = $wgRequest->getVal( 'fromsection' );
460	460	if ( $anchor != null ) {
461	461	$section = str_replace( '_', ' ', $anchor ); // prettify
—	—	@@ -476,13 +476,13 @@
477	477	$msg = $quality
478	478	? 'revreview-quick-quality-same'
479	479	: 'revreview-quick-basic-same';
480		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ),~~
	480	+ $msgHTML = wfMsgExt( $msg, 'parseinline',
481	481	$srev->getRevId(), $revsSince );
482	482	} else {
483	483	$msg = $quality
484	484	? 'revreview-quick-see-quality'
485	485	: 'revreview-quick-see-basic';
486		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ),~~
	486	+ $msgHTML = wfMsgExt( $msg, 'parseinline',
487	487	$srev->getRevId(), $revsSince );
488	488	}
489	489	$icon = '';
—	—	@@ -503,14 +503,14 @@
504	504	} else {
505	505	$msg = 'revreview-basic-same';
506	506	}
507		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ),~~
	507	+ $msgHTML = wfMsgExt( $msg, 'parseinline',
508	508	$srev->getRevId(), $time, $revsSince );
509	509	} else {
510	510	$msg = $quality
511	511	? 'revreview-newest-quality'
512	512	: 'revreview-newest-basic';
513	513	$msg .= ( $revsSince == 0 ) ? '-i' : '';
514		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ),~~
	514	+ $msgHTML = wfMsgExt( $msg, 'parseinline',
515	515	$srev->getRevId(), $time, $revsSince );
516	516	}
517	517	$icon = $synced
—	—	@@ -558,7 +558,7 @@
559	559	$msg = $quality
560	560	? 'revreview-quick-quality-old'
561	561	: 'revreview-quick-basic-old';
562		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ), $frev->getRevId(), $revsSince );~~
	562	+ $msgHTML = wfMsgExt( $msg, 'parseinline', $frev->getRevId(), $revsSince );
563	563	}
564	564	$msgHTML = $prot . $icon . $msgHTML;
565	565	$tag = FlaggedRevsXML::prettyRatingBox( $frev, $msgHTML,
—	—	@@ -634,7 +634,7 @@
635	635	: 'revreview-quick-basic';
636	636	# Uses messages 'revreview-quick-quality-same', 'revreview-quick-basic-same'
637	637	$msg = $synced ? "{$msg}-same" : $msg;
638		~~- $msgHTML = wfMsgExt( $msg, array( 'parseinline' ),~~
	638	+ $msgHTML = wfMsgExt( $msg, 'parseinline',
639	639	$srev->getRevId(), $revsSince );
640	640	}
641	641	$msgHTML = $prot . $icon . $msgHTML;
—	—	@@ -916,7 +916,7 @@
917	917	# Let new users know about review procedure a tag.
918	918	# If the log excerpt was shown this is redundant.
919	919	if ( !$log && !$wgUser->getId() && $this->article->isStableShownByDefault() ) {
920		~~- $items[] = wfMsgExt( 'revreview-editnotice', array( 'parseinline' ) );~~
	920	+ $items[] = wfMsgExt( 'revreview-editnotice', 'parseinline' );
921	921	}
922	922	# Add a notice if there are pending edits...
923	923	if ( $this->article->revsArePending() ) {
—	—	@@ -1002,7 +1002,7 @@
1003	1003	$revsSince = $this->article->getPendingRevCount();
1004	1004	if ( $revsSince ) {
1005	1005	$s .= "<div class='flaggedrevs_editnotice plainlinks'>" .
1006		~~- wfMsgExt( 'revreview-pending-nosection', array( 'parseinline' ),~~
	1006	+ wfMsgExt( 'revreview-pending-nosection', 'parseinline',
1007	1007	$srev->getRevId(), $revsSince ) . "</div>";
1008	1008	}
1009	1009	}
—	—	@@ -1109,15 +1109,15 @@
1110	1110	$frev = $this->article->getStableRev();
1111	1111	if ( $frev && $frev->getRevId() == $this->article->getLatest() ) {
1112	1112	$wgOut->prependHTML( "<span class='plainlinks'>" .
1113		~~- wfMsgExt( 'revreview-visibility', array( 'parseinline' ),~~
	1113	+ wfMsgExt( 'revreview-visibility', 'parseinline',
1114	1114	$title->getPrefixedText() ) . "</span>" );
1115	1115	} elseif ( $frev ) {
1116	1116	$wgOut->prependHTML( "<span class='plainlinks'>" .
1117		~~- wfMsgExt( 'revreview-visibility2', array( 'parseinline' ),~~
	1117	+ wfMsgExt( 'revreview-visibility2', 'parseinline',
1118	1118	$title->getPrefixedText() ) . "</span>" );
1119	1119	} else {
1120	1120	$wgOut->prependHTML( "<span class='plainlinks'>" .
1121		~~- wfMsgExt( 'revreview-visibility3', array( 'parseinline' ),~~
	1121	+ wfMsgExt( 'revreview-visibility3', 'parseinline',
1122	1122	$title->getPrefixedText() ) . "</span>" );
1123	1123	}
1124	1124	}

Status & tagging log

13:06, 15 February 2011 😂 (talk | contribs) changed the status of r81811 [removed: new added: ok]