r81799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81798‎ | r81799 | r81800 >
Date:00:03, 9 February 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
param name tweak
Modified paths:
  • /trunk/extensions/SemanticResultFormats/SRF_Messages.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php
@@ -35,11 +35,11 @@
3636 protected function readParameters( $params, $outputmode ) {
3737 parent::readParameters( $params, $outputmode );
3838
39 - if ( !array_key_exists( 'includename', $params ) || !in_array( $params['includename'], array( 'yes', 'no' ) ) ) {
40 - $params['includename'] = 'no';
 39+ if ( !array_key_exists( 'includesubject', $params ) || !in_array( $params['includesubject'], array( 'yes', 'no' ) ) ) {
 40+ $params['includesubject'] = 'no';
4141 }
4242
43 - $this->includeName = $params['includename'] == 'yes';
 43+ $this->includeName = $params['includesubject'] == 'yes';
4444
4545 if ( !array_key_exists( 'increase', $params ) || !in_array( $params['increase'], array( 'linear', 'log' ) ) ) {
4646 $params['increase'] = 'log';
@@ -268,7 +268,7 @@
269269 public function getParameters() {
270270 $params = parent::getParameters();
271271
272 - $params[] = array( 'name' => 'includename', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_includename' ), 'values' => array( 'yes', 'no' ) );
 272+ $params[] = array( 'name' => 'includesubject', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_includesubject' ), 'values' => array( 'yes', 'no' ) );
273273 $params[] = array( 'name' => 'increase', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_increase' ), 'values' => array( 'linear', 'log' ) );
274274 $params[] = array( 'name' => 'tagorder', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_tagorder' ), 'values' => array( 'alphabetic', 'asc', 'desc', 'random', 'unchanged' ) );
275275
Index: trunk/extensions/SemanticResultFormats/SRF_Messages.php
@@ -80,7 +80,7 @@
8181
8282 // "tagcloud" format
8383 'srf_printername_tagcloud' => 'Tag cloud',
84 - 'srf_paramdesc_includename' => 'If the names of the object themselves should be included',
 84+ 'srf_paramdesc_includesubject' => 'If the names of the subjects themselves should be included',
8585 'srf_paramdesc_increase' => 'How to increase the size of tags',
8686 'srf_paramdesc_tagorder' => 'The order of the tags',
8787 'srf_paramdesc_mincount' => 'The minimum amount of times a value needs to occur to be listed',

Status & tagging log