r81791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81790‎ | r81791 | r81792 >
Date:23:09, 8 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Minor documentation tweaks/improvements
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -143,6 +143,7 @@
144144 return $cacheEntry;
145145 }
146146
 147+ $result = '';
147148 // Run the filter - we've already verified one of these will work
148149 try {
149150 switch ( $filter ) {
@@ -253,7 +254,7 @@
254255 * Get the ResourceLoaderModule object for a given module name.
255256 *
256257 * @param $name String: Module name
257 - * @return Mixed: ResourceLoaderModule if module has been registered, null otherwise
 258+ * @return ResourceLoaderModule if module has been registered, null otherwise
258259 */
259260 public function getModule( $name ) {
260261 if ( !isset( $this->modules[$name] ) ) {
Index: trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -27,7 +27,11 @@
2828 protected $modifiedTime = array();
2929
3030 /* Protected Methods */
31 -
 31+
 32+ /**
 33+ * @param $context ResourceLoaderContext
 34+ * @return array
 35+ */
3236 protected function getConfig( $context ) {
3337 global $wgLoadScript, $wgScript, $wgStylePath, $wgScriptExtension,
3438 $wgArticlePath, $wgScriptPath, $wgServer, $wgContLang,
Index: trunk/phase3/includes/resourceloader/ResourceLoaderWikiModule.php
@@ -44,7 +44,11 @@
4545 abstract protected function getPages( ResourceLoaderContext $context );
4646
4747 /* Protected Methods */
48 -
 48+
 49+ /**
 50+ * @param $title Title
 51+ * @return null|string
 52+ */
4953 protected function getContent( $title ) {
5054 if ( $title->getNamespace() === NS_MEDIAWIKI ) {
5155 $dbkey = $title->getDBkey();

Status & tagging log