r81694 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81693‎ | r81694 | r81695 >
Date:07:04, 8 February 2011
Author:catrope
Status:ok
Tags:
Comment:
WikiEditor: Add some var statements to code introduced in r74271
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js
@@ -106,7 +106,7 @@
107107 */
108108 'isRequired': function( module, requirement ) {
109109 if ( typeof module['req'] !== 'undefined' ) {
110 - for ( req in module['req'] ) {
 110+ for ( var req in module['req'] ) {
111111 if ( module['req'][req] == requirement ) {
112112 return true;
113113 }
@@ -595,11 +595,11 @@
596596 modules = {};
597597 modules[args[1]] = '';
598598 }
599 - for ( module in modules ) {
 599+ for ( var module in modules ) {
600600 // Only allow modules which are supported (and thus actually being turned on) affect the decision to extend
601601 if ( module in $.wikiEditor.modules && $.wikiEditor.isSupported( $.wikiEditor.modules[module] ) ) {
602602 // Activate all required core extensions on context
603 - for ( e in $.wikiEditor.extensions ) {
 603+ for ( var e in $.wikiEditor.extensions ) {
604604 if (
605605 $.wikiEditor.isRequired( $.wikiEditor.modules[module], e ) &&
606606 context.extensions.indexOf( e ) === -1

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74271* Introduced the concept of context extensions...tparscal20:12, 4 October 2010

Status & tagging log