r81691 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81690‎ | r81691 | r81692 >
Date:06:21, 8 February 2011
Author:dale
Status:deferred
Tags:
Comment:
minor fixes for RL_1_17 ( Add media wizard ) still needs to be fixed
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css (modified) (history)
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSideSeek.html (modified) (history)
  • /branches/MwEmbedStandAlone/modules/P2PNextTransport/mw.P2PNextTransport.js (modified) (history)
  • /branches/MwEmbedStandAlone/mwEmbed.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/mwEmbed.js
@@ -2146,7 +2146,7 @@
21472147 // Special Hack for conditional jquery ui inclusion (
21482148 // once
21492149 // Usability extension
2150 - // registers the jquery.ui skin in mw.style
 2150+ // registers the jquery.ui skin in mw.style
21512151 if( mw.hasJQueryUiCss() ){
21522152 mw.style[ 'ui_' + mw.getConfig( 'jQueryUISkin' ) ] = true;
21532153 }
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSideSeek.html
@@ -1,14 +1,30 @@
22 <html>
33 <head>
4 - <script type="text/javascript" src="http://html5.kaltura.org/js"></script>
 4+ <script type="text/javascript" src="../../../mwEmbedLoader.js"></script>
55 </head>
66 <body>
77 <h2>mwEmbed / archive.org server side seek</h2>
8 -
9 - <video poster="http://www.archive.org/download/night_of_the_living_dead/format=Thumbnail&x.jpg"
 8+ Start Playing at <input id="startTime" size="5" value ="20"></input> seconds. <input value="go" type="button" id="doPageSeek"></input></br>
 9+ <video id="vid1" poster="http://www.archive.org/download/night_of_the_living_dead/format=Thumbnail&x.jpg"
1010 style="width:400px;height:300px" durationHint="5717.21">
11 - <source URLTimeEncoding="true" src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead_512kb.mp4"/>
12 - <source URLTimeEncoding="true" src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead.ogv"/>
 11+ <source src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead_512kb.mp4"/>
 12+ <source src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead.ogv"/>
1313 </video>
 14+ <script type="text/javascript">
 15+ mw.ready( function(){
 16+ // check for hash:
 17+ var urlParts = mw.parseUri( document.URL);
 18+ if( urlParts.anchor ){
 19+ // run the start offset:
 20+ var startTime = urlParts.anchor.split('=')[1];
 21+ $j('#vid1').get(0).currentTime = startTime;
 22+ $j('#vid1').get(0).play();
 23+ }
 24+ // bind button:
 25+ $j('#doPageSeek').click(function(){
 26+ document.location = 'Player_ServerSideSeek.html?' + Math.random(1) + '#start=' + $j("#startTime").val();
 27+ });
 28+ });
 29+ </script>
1430 </body>
1531 </html>
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css
@@ -161,6 +161,7 @@
162162 font-family: Lucida Grande, Lucida Sans, Arial, sans-serif;
163163 font-size: 11px;
164164 text-transform: uppercase;
 165+ text-align: center;
165166 }
166167
167168 .k-player .k-options span {
Index: branches/MwEmbedStandAlone/modules/P2PNextTransport/mw.P2PNextTransport.js
@@ -16,7 +16,7 @@
1717
1818 // Add the P2PNextTransport player to available player types:
1919 $j( mw ).bind( 'EmbedPlayerManagerReady', function( event ) {
20 - $.each( _this.getTransportObjects(), function(na, transportObject ){
 20+ $j.each( _this.getTransportObjects(), function(na, transportObject ){
2121
2222 // Add the transportObject playerType
2323 mw.EmbedTypes.getMediaPlayers().defaultPlayers[ transportObject.mime ] = [ transportObject.playerLib ];
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r190';
 8+var mwRemoteVersion = 'r191';
99
1010 // Log the mwRemote version makes it easy to debug cache issues
1111 if( window.console ){
@@ -344,7 +344,7 @@
345345 return oldBodyHTML;
346346 }
347347 function mwAddCommonStyleSheet(){
348 - importStylesheetURI( mwEmbedHostPath + '/skins/common/mw.style.mwCommon.css?' + mwGetReqArgs() );
 348+ importStylesheetURI( mwEmbedHostPath + '/skins/common/mw.style.mwCommon.css?' + mwGetReqArgs() );
349349 // Set the style to defined ( so that when mw won't load the style sheet again)
350350 if( !mw.style ){
351351 mw.style = { 'mwCommon' : true };
@@ -360,6 +360,7 @@
361361 // The jsPlayerRequest includes both javascript and style sheets for the embedPlayer
362362 var jsPlayerRequest = [
363363 '$j.ui',
 364+ 'mw.style.ui_redmond',
364365 '$j.widget',
365366 '$j.ui.mouse',
366367
@@ -451,7 +452,12 @@
452453 }else{
453454 //mw.log(" rewrite: " + rewriteHTML + "\n of type: " + typeof rewriteHTML);
454455 }
 456+
455457 var re = new RegExp( /videoUrl(&quot;:?\s*)*([^&]*)/ );
 458+ var srcParts = re.exec( rewriteHTML );
 459+ if(!srcParts){
 460+ return ;
 461+ }
456462 src = re.exec( rewriteHTML )[2];
457463
458464 var timeHash = '';
@@ -678,7 +684,7 @@
679685 * @return {Boolean} true if objectPath exists false if objectPath is
680686 * undefined
681687 */
682 -mwIsset = function( objectPath ) {
 688+window.mwIsset = function( objectPath ) {
683689 if ( !objectPath || typeof objectPath != 'string') {
684690 return false;
685691 }
@@ -927,4 +933,4 @@
928934 }
929935 }
930936 return false;
931 -}
\ No newline at end of file
 937+}

Status & tagging log