r81677 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81676‎ | r81677 | r81678 >
Date:01:15, 8 February 2011
Author:dantman
Status:ok
Tags:
Comment:
Fix bug slightly caused by moving legacy code out of the Skin class. The Article class was calling the legacy Skin::historyLink in a very ugly way (ie: having it's own mTitle, but relying on whatever title just happened to be set on the skin that it grabbed).
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -2911,7 +2911,10 @@
29122912 //FIXME: lego
29132913 $wgOut->addHTML( '<strong class="mw-delete-warning-revisions">' .
29142914 wfMsgExt( 'historywarning', array( 'parseinline' ), $wgLang->formatNum( $revisions ) ) .
2915 - wfMsgHtml( 'word-separator' ) . $skin->historyLink() .
 2915+ wfMsgHtml( 'word-separator' ) . $skin->link( $this->mTitle,
 2916+ wfMsgHtml( 'history' ),
 2917+ array( 'rel' => 'archives' ),
 2918+ array( 'action' => 'history' ) ) .
29162919 '</strong>'
29172920 );
29182921

Status & tagging log