r81608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81607‎ | r81608 | r81609 >
Date:21:47, 6 February 2011
Author:brion
Status:ok
Tags:
Comment:
Fixed an incorrect doc comment bit on Database::sourceStream, then added some more doc comments around the file just cause
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -2494,7 +2494,7 @@
24952495 /**
24962496 * Read and execute commands from an open file handle
24972497 * Returns true on success, error string or exception on failure (depending on object's error ignore settings)
2498 - * @param $fp String: File handle
 2498+ * @param $fp Resource: File handle
24992499 * @param $lineCallback Callback: Optional function called before reading each line
25002500 * @param $resultCallback Callback: Optional function called for each MySQL result
25012501 * @param $fname String: Calling function name
@@ -3124,6 +3124,9 @@
31253125
31263126 /**
31273127 * Create a new result object from a result resource and a Database object
 3128+ *
 3129+ * @param Database $database
 3130+ * @param resource $result
31283131 */
31293132 function __construct( $database, $result ) {
31303133 $this->db = $database;
@@ -3137,6 +3140,8 @@
31383141
31393142 /**
31403143 * Get the number of rows in a result object
 3144+ *
 3145+ * @return integer
31413146 */
31423147 function numRows() {
31433148 return $this->db->numRows( $this );
@@ -3175,8 +3180,10 @@
31763181 }
31773182
31783183 /**
3179 - * Change the position of the cursor in a result object
 3184+ * Change the position of the cursor in a result object.
31803185 * See mysql_data_seek()
 3186+ *
 3187+ * @param $row integer
31813188 */
31823189 function seek( $row ) {
31833190 $this->db->dataSeek( $this, $row );
@@ -3266,10 +3273,20 @@
32673274 class LikeMatch {
32683275 private $str;
32693276
 3277+ /**
 3278+ * Store a string into a LikeMatch marker object.
 3279+ *
 3280+ * @param String $s
 3281+ */
32703282 public function __construct( $s ) {
32713283 $this->str = $s;
32723284 }
32733285
 3286+ /**
 3287+ * Return the original stored string.
 3288+ *
 3289+ * @return String
 3290+ */
32743291 public function toString() {
32753292 return $this->str;
32763293 }

Status & tagging log