r81412 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81411‎ | r81412 | r81413 >
Date:20:25, 2 February 2011
Author:catrope
Status:ok
Tags:
Comment:
Merge r80947 from 1.16wmf4 to trunk: throw exception when text couldn't be loaded from archive table
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -82,6 +82,9 @@
8383 if ( isset( $row->ar_text ) && !$row->ar_text_id ) {
8484 // Pre-1.5 ar_text row
8585 $attribs['text'] = self::getRevisionText( $row, 'ar_' );
 86+ if ( $attribs['text'] === false ) {
 87+ throw new MWException( 'Unable to load text from archive row (possibly bug 22624)' );
 88+ }
8689 }
8790 return new self( $attribs );
8891 }
Property changes on: trunk/phase3/includes/Revision.php
___________________________________________________________________
Added: svn:mergeinfo
8992 Merged /branches/sqlite/includes/Revision.php:r58211-58321
9093 Merged /branches/new-installer/phase3/includes/Revision.php:r43664-66004
9194 Merged /branches/wmf-deployment/includes/Revision.php:r53381
9295 Merged /branches/REL1_15/phase3/includes/Revision.php:r51646
9396 Merged /branches/wmf/1.16wmf4/includes/Revision.php:r80947

Follow-up revisions

RevisionCommit summaryAuthorDate
r814131.17: MFT r78395, r79968, r81311, r81313, r81349, r81352, r81376, r81389, r81...catrope20:45, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r809471.16wmf4: Commit live hack: throw exception when text couldn't be loaded from...catrope00:27, 25 January 2011

Status & tagging log