r81390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81389‎ | r81390 | r81391 >
Date:14:26, 2 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup fixme on r81198, explicitally ORDER BY qc_value ASC if not doing DESC
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -409,6 +409,8 @@
410410 }
411411 if ( $this->sortDescending() ) {
412412 $options['ORDER BY'] = 'qc_value DESC';
 413+ } else {
 414+ $options['ORDER BY'] = 'qc_value ASC';
413415 }
414416 $res = $dbr->select( 'querycache', array( 'qc_type',
415417 'qc_namespace AS namespace',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81198Per fixme on r78786, obey sortDescending in Cached mode (ie if sortDescending...reedy22:07, 29 January 2011

Status & tagging log