r81369 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81368‎ | r81369 | r81370 >
Date:01:24, 2 February 2011
Author:dale
Status:deferred
Tags:
Comment:
updated durationHint attribute to data-durationhint
Modified paths:
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/README (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/AdSupport/tests/Ad_Events_test.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/players/mw.EmbedPlayer.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Audio.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Seek.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSeek.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSideSeek.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Sources.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Themable.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/kalturaIframe.php (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/mw.PlaylistHandlerKaltura.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/mw.PlaylistHandlerKalturaRss.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/MediaWikiSupport/tests/Player_mwtitle.html (added) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Playlist/mw.PlaylistHandlerMediaRss.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/mw.SequencerAddMedia.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/tests/VideoRender.xml (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoCrossfadeSmil.xml (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoRender.xml (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoTransitionSmil.xml (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/TimedText/tests/Player_Timed_Text.html (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/mwEmbedFrame.php (modified) (history)
  • /branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/mwEmbedFrame.php
——@@ -43,7 +43,7 @@
4444 var $playerAttributes = array(
4545 'apiTitleKey',
4646 'apiProvider',
47 - 'durationHint',
 47+ 'data-durationhint',
4848 'poster',
4949 'kentryid',
5050 'kwidgetid',
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/AdSupport/tests/Ad_Events_test.html
——@@ -9,7 +9,7 @@
1010 <div class="playerContainer" style="float:left;width:480px;height:290px;top:0px;left:0px;position:absolute;">
1111 <video class="persistentNativePlayer" id="vid1" width="480" height="300"
1212 poster="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb480.jpg"
13 - durationHint="33"
 13+ data-durationhint="33"
1414 >
1515 <source src="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb_trailer_iphone.m4v" />
1616 <source src="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb400p.ogv" />
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoCrossfadeSmil.xml
——@@ -27,7 +27,7 @@
2828 transIn="fromGreen"
2929 type="video/ogg"
3030 fill="transition"
31 - durationHint="15"
 31+ data-durationhint="15"
3232 dur="9s"
3333 />
3434
——@@ -37,7 +37,7 @@
3838
3939 fill="transition"
4040 dur="10s"
41 - durationHint="70"
 41+ data-durationhint="70"
4242 type="video/ogg"
4343 />
4444
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoRender.xml
——@@ -33,7 +33,7 @@
3434 transIn="fromBlack"
3535 type="video/ogg"
3636 fill="transition"
37 - durationHint="15"
 37+ data-durationhint="15"
3838 dur="9s"
3939 />
4040
——@@ -43,7 +43,7 @@
4444
4545 fill="transition"
4646 dur="10s"
47 - durationHint="70"
 47+ data-durationhint="70"
4848 type="video/ogg"
4949 />
5050
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/SmilPlayer/tests/VideoTransitionSmil.xml
——@@ -36,7 +36,7 @@
3737 transOut="xFade"
3838 type="video/ogg"
3939 fill="transition"
40 - durationHint="15"
 40+ data-durationhint="15"
4141 dur="9s"
4242 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/d/d3/Okapia_johnstoni5.ogg/mid-Okapia_johnstoni5.ogg.jpg"
4343 />
——@@ -44,7 +44,7 @@
4545 <video src="http://upload.wikimedia.org/wikipedia/commons/0/0d/B-36_bomber.ogg"
4646 fill="transition"
4747 dur="10s"
48 - durationHint="70"
 48+ data-durationhint="70"
4949 type="video/ogg"
5050 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/0/0d/B-36_bomber.ogg/mid-B-36_bomber.ogg.jpg"
5151 />
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/players/mw.EmbedPlayer.js
——@@ -31,7 +31,7 @@
3232
3333 // A hint to the duration of the media file so that duration
3434 // can be displayed in the player without loading the media file
35 - 'durationHint',
 35+ 'data-durationhint',
3636
3737 // Media start time
3838 'start',
——@@ -112,7 +112,7 @@
113113 "preMuteVolume" : 0.75,
114114
115115 // Media duration: Value is populated via
116 - // custom durationHint attribute or via the media file once its played
 116+ // custom data-durationhint attribute or via the media file once its played
117117 "duration" : null,
118118
119119 // Mute state
——@@ -302,7 +302,7 @@
303303 } else {
304304 // Check if we should wait for duration:
305305 if( $( playerElement ).attr( 'duration') ||
306 - $( playerElement ).attr('durationHint')
 306+ $( playerElement ).attr('data-durationhint')
307307 ){
308308 // height, width and duration set; do not wait for meta data:
309309 return false;
——@@ -1339,15 +1339,15 @@
13401340 this.startOffset = parseFloat( this.startOffset );
13411341
13421342 // Set the source duration ( if provided in the element metaData or
1343 - // durationHint )
 1343+ // data-durationhint )
13441344 if ( $( element ).attr( 'duration' ) ) {
13451345 _this.duration = $( element ).attr( 'duration' );
13461346 }
13471347
1348 - if ( !_this.duration && $( element ).attr( 'durationHint' ) ) {
1349 - _this.durationHint = $( element ).attr( 'durationHint' );
 1348+ if ( !_this.duration && $( element ).attr( 'data-durationhint' ) ) {
 1349+ _this.data-durationhint = $( element ).attr( 'data-durationhint' );
13501350 // Convert duration hint if needed:
1351 - _this.duration = mw.npt2seconds( _this.durationHint );
 1351+ _this.duration = mw.npt2seconds( _this.data-durationhint );
13521352 }
13531353
13541354 // Make sure duration is a float:
——@@ -2386,7 +2386,7 @@
23872387 }
23882388
23892389 if( this.duration ) {
2390 - params.durationHint = parseFloat( this.duration );
 2390+ params.data-durationhint = parseFloat( this.duration );
23912391 }
23922392 iframeUrl += $j.param( params );
23932393
——@@ -2437,7 +2437,7 @@
24382438 }
24392439
24402440 if( this.duration ) {
2441 - embedCode +='durationHint=&quot;' + parseFloat( this.duration ) + '&quot; ';
 2441+ embedCode +='data-durationhint=&quot;' + parseFloat( this.duration ) + '&quot; ';
24422442 }
24432443
24442444 if( this.width || this.height ){
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Audio.html
——@@ -10,6 +10,6 @@
1111 </head>
1212 <body>
1313 <h3> Audio Player </h3>
14 -<audio class="kskin" src="http://upload.wikimedia.org/wikipedia/commons/4/4c/Faurepiece.ogg" durationHint="164"></audio>
 14+<audio class="kskin" src="http://upload.wikimedia.org/wikipedia/commons/4/4c/Faurepiece.ogg" data-durationhint="164"></audio>
1515 </body>
1616 </html>
\ No newline at end of file
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Themable.html
——@@ -26,7 +26,7 @@
2727 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/2/29/Charles_Lindbergh_flight_to_Brussels.ogg/mid-Charles_Lindbergh_flight_to_Brussels.ogg.jpg"
2828 data-mwtitle="Charles_Lindbergh_flight_to_Brussels.ogg"
2929 data-mwprovider="commons"
30 - durationHint="60" >
 30+ data-durationhint="60" >
3131 </video>
3232
3333 <video
——@@ -35,7 +35,7 @@
3636 data-mwtitle="Charles_Lindbergh_flight_to_Brussels.ogg"
3737 data-mwprovider="commons"
3838 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/2/29/Charles_Lindbergh_flight_to_Brussels.ogg/mid-Charles_Lindbergh_flight_to_Brussels.ogg.jpg"
39 - durationHint="60">
 39+ data-durationhint="60">
4040 </video>
4141
4242 <b>Source Code used:</b><br>
——@@ -51,7 +51,7 @@
5252 data-mwtitle="Charles_Lindbergh_flight_to_Brussels.ogg"
5353 data-mwprovider="commons"
5454 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/2/29/Charles_Lindbergh_flight_to_Brussels.ogg/mid-Charles_Lindbergh_flight_to_Brussels.ogg.jpg"
55 - durationHint="60">
 55+ data-durationhint="60">
5656 </video>
5757 <video
5858 class="kskin"
——@@ -59,7 +59,7 @@
6060 data-mwprovider="commons"
6161 style="width:208px;height:160px;float:left;" src="http://upload.wikimedia.org/wikipedia/commons/2/29/Charles_Lindbergh_flight_to_Brussels.ogg"
6262 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/2/29/Charles_Lindbergh_flight_to_Brussels.ogg/mid-Charles_Lindbergh_flight_to_Brussels.ogg.jpg"
63 - durationHint="60">
 63+ data-durationhint="60">
6464 </video>
6565
6666 <b>(kskin) Source Code used:</b><br>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSideSeek.html
——@@ -6,7 +6,7 @@
77 <h2>mwEmbed / archive.org server side seek</h2>
88
99 <video poster="http://www.archive.org/download/night_of_the_living_dead/format=Thumbnail&x.jpg"
10 - style="width:400px;height:300px" durationHint="5717.21">
 10+ style="width:400px;height:300px" data-durationhint="5717.21">
1111 <source URLTimeEncoding="true" src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead_512kb.mp4"/>
1212 <source URLTimeEncoding="true" src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead.ogv"/>
1313 </video>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Sources.html
——@@ -10,7 +10,7 @@
1111
1212 <video id="vid1" width="480" height="267"
1313 poster="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb480.jpg"
14 - durationHint="33"
 14+ data-durationhint="33"
1515 controls>
1616 <source src="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb_trailer_iphone.m4v">
1717 <source src="http://cdn.kaltura.org/apis/html5lib/kplayer-examples/media/bbb400p.ogv" />
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_Seek.html
——@@ -7,7 +7,7 @@
88 <h2>mwEmbed / archive.org server side seek</h2>
99 Start Playing at <input id="startTime" size="5" value ="50"></input> seconds. <input value="go" type="button" id="doPageSeek"></input></br>
1010 <video id="vid1" poster="http://www.archive.org/download/night_of_the_living_dead/format=Thumbnail&x.jpg"
11 - style="width:400px;height:300px" durationHint="5717.21">
 11+ style="width:400px;height:300px" data-durationhint="5717.21">
1212 <source src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead_512kb.mp4"/>
1313 <source src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead.ogv"/>
1414 </video>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/EmbedPlayer/tests/Player_ServerSeek.html
——@@ -1,12 +1,12 @@
22 <html>
33 <head>
4 - <script type="text/javascript" src="../../../mwEmbedLoader.js"></script>
 4+ <script type="text/javascript" src="../../../load.php?modules=startup&only=scripts"></script>
55 </head>
66 <body>
77 <h2>mwEmbed / archive.org server side seek</h2>
88 Start Playing at <input id="startTime" size="5" value="50"></input> seconds. <input value="go" type="button" id="doPageSeek"></input></br>
99 <video id="vid1" poster="http://www.archive.org/download/night_of_the_living_dead/format=Thumbnail&x.jpg"
10 - style="width:400px;height:300px" durationHint="5717.21">
 10+ style="width:400px;height:300px" data-durationhint="5717.21">
1111 <source URLTimeEncoding='true' src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead_512kb.mp4"/>
1212 <source URLTimeEncoding='true' src="http://www.archive.org/download/night_of_the_living_dead/night_of_the_living_dead.ogv"/>
1313 </video>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/mw.SequencerAddMedia.js
——@@ -222,7 +222,7 @@
223223 // Set the default duration to the media duration:
224224 if( resource.duration ){
225225 // Set the media full duration
226 - $smilRef.attr( 'durationHint', resource.duration );
 226+ $smilRef.attr( 'data-durationhint', resource.duration );
227227 // By default the imported resource is its entire duration
228228 $smilRef.attr( 'dur', resource.duration );
229229 }
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/tests/VideoRender.xml
——@@ -50,7 +50,7 @@
5151
5252 fill="transition"
5353 dur="1000s"
54 - durationHint="70"
 54+ data-durationhint="70"
5555 type="video/ogg"
5656 />
5757
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js
——@@ -373,7 +373,7 @@
374374 .attr({
375375 'id' : 'embedSequencePlayer',
376376 'poster' : imageinfo.thumburl,
377 - 'durationHint' : duration,
 377+ 'data-durationhint' : duration,
378378 'apiTitleKey' : page.title.replace('File:',''),
379379 })
380380 .addClass('kskin')
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/mw.PlaylistHandlerKaltura.js
——@@ -144,9 +144,9 @@
145145 getClipSources: function( clipIndex, callback ){
146146 var _this = this;
147147 mw.getEntryIdSourcesFromApi( this.getKClient().getPartnerId(), this.getClipList()[ clipIndex ].id, function( sources ){
148 - // Add the durationHint to the sources:
 148+ // Add the data-durationhint to the sources:
149149 for( var i in sources){
150 - sources[i].durationHint = _this.getClipDuration( clipIndex );
 150+ sources[i].data-durationhint = _this.getClipDuration( clipIndex );
151151 }
152152 callback( sources );
153153 });
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/mw.PlaylistHandlerKalturaRss.js
——@@ -43,7 +43,7 @@
4444
4545 mw.getEntryIdSourcesFromApi( kalturaEntryId , function( sources ){
4646 for( var i in sources ){
47 - sources[i].durationHint = clipDuration;
 47+ sources[i].data-durationhint = clipDuration;
4848 }
4949 callback( sources );
5050 });
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/KalturaSupport/kalturaIframe.php
——@@ -614,7 +614,7 @@
615615 mw.setConfig( 'Kaltura.LoadScriptForVideoTags', false );
616616
617617 // Don't wait for player metada for size layout and duration ( won't be needed once
618 - // we add durationHint and size attributes to the video tag
 618+ // we add data-durationhint and size attributes to the video tag
619619 mw.setConfig( 'EmbedPlayer.WaitForMeta', false );
620620
621621 // Add Packaging Kaltura Player Data ( JSON Encoded )
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/MediaWikiSupport/tests/Player_mwtitle.html
——@@ -0,0 +1,9 @@
 2+
 3+
 4+
 5+<video id="v0" tabindex="0" style="width: 512px; height: 288px;"
 6+data-durationhint="7:52"
 7+data-="Yochai_Benkler_-_On_Autonomy,_Control_and_Cultural_Experience.ogg"
 8+apiprovider="commons"
 9+class="kskin">
 10+</video>
\ No newline at end of file
Property changes on: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/MediaWikiSupport/tests/Player_mwtitle.html
___________________________________________________________________
Added: svn:mime-type
111 + text/plain
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/Playlist/mw.PlaylistHandlerMediaRss.js
——@@ -63,7 +63,7 @@
6464 clipSource.type = $( mediaContent ).attr('type' );
6565 }
6666 if( $( mediaContent ).attr( 'duration' ) ) {
67 - clipSource.durationHint = $( mediaContent ).attr('duration' );
 67+ clipSource.data-durationhint = $( mediaContent ).attr('duration' );
6868 }
6969 clipSources.push( clipSource );
7070 }
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/TimedText/tests/Player_Timed_Text.html
——@@ -3,8 +3,9 @@
44 <html>
55 <head>
66 <title>sample mv embed</title>
7 - <!-- <script type="text/javascript" src="../../../ResourceLoader.php?class=window.jQuery,mwEmbed&&debug=true"></script> -->
8 - <script type="text/javascript" src="../../../ResourceLoader.php?class=window.jQuery,mwEmbed&debug=true"></script>
 7+
 8+ <script type="text/javascript" src="../../../load.php?modules=startup&only=scripts"></script>
 9+
910 <script type="text/javascript">
1011 $( document ).ready(function(){
1112 $('#inlineTracksTextArea').text(
——@@ -26,7 +27,7 @@
2728 <td id="apiExample" valign="top" width="410">
2829 <video
2930 style="width:512px;height:288px"
30 - durationHint="7:52"
 31+ data-durationhint="7:52"
3132 apititlekey="Yochai_Benkler_-_On_Autonomy,_Control_and_Cultural_Experience.ogg"
3233 apiProvider="commons"
3334 class="kskin"></video>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js
——@@ -60,7 +60,7 @@
6161 'id': "timed-text-player-embed",
6262 'poster': resource.poster,
6363 'src': resource.src,
64 - 'durationHint' : resource.duration,
 64+ 'data-durationhint' : resource.duration,
6565 'apiTitleKey' : resource.apiTitleKey
6666 })
6767 .css({
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/README
——@@ -83,7 +83,7 @@
8484 </body>
8585 </html>
8686
87 -* For best compatibility: we include the poster, durationHint, width and height attributes. This way browsers such as IE can display the player interface with poster image at the correct resolution with a duration in the user interface.
 87+* For best compatibility: we include the poster, data-durationhint, width and height attributes. This way browsers such as IE can display the player interface with poster image at the correct resolution with a duration in the user interface.
8888 * If you would like to support html5 with h.264 ( safari, IE9, google chrome) and support a flash fallback for older versions of IE you include an h.264 source. For best compatibility your mp4 source should ideally use a h.264 profile compatible with mobile devices such as the iPhone. <a href="http://corp.kaltura.com/">Kaltura hosted Solutions</a> include iPhone support. Desktop video encoding software such as <a href="http://handbrake.fr/">handbrake</a> also includes iPhone profiles.
8989 * If you would like to change the theme you can change the class attribute `<video class="kskin">` more info about custom theming is on the way.
9090
——@@ -176,7 +176,7 @@
177177
178178 Now in your HTML you can use the video tag and it will be given a user interface ie:
179179
180 - <video poster="myPoster.jpg" style="width:400px;height:300px" durationHint="32.2" >
 180+ <video poster="myPoster.jpg" style="width:400px;height:300px" data-durationhint="32.2" >
181181 <source src="myH.264.mp4" />
182182 <source src="myOgg.ogg" />
183183 </video>
Index: branches/MwEmbedStandAloneRL1_17/MwEmbedStandAlone/remotes/mediaWiki.js
——@@ -452,7 +452,7 @@
453453
454454 var re = new RegExp( /length(&quot;:?\s*)*([^,]*)/ );
455455 var dv = parseFloat( re.exec( rewriteHTML )[2] );
456 - duration_attr = ( dv )? 'durationHint="' + dv + '" ': '';
 456+ duration_attr = ( dv )? 'data-durationhint="' + dv + '" ': '';
457457
458458 var re = new RegExp( /offset(&quot;:?\s*)*([^,&]*)/ );
459459 offset = re.exec( rewriteHTML );

Status & tagging log