r81259 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81258‎ | r81259 | r81260 >
Date:17:13, 31 January 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r81258
Modified paths:
  • /trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php
@@ -174,7 +174,7 @@
175175 while ( ( $object = $field->getNextObject() ) !== false ) { // Loop over property values
176176 $event = $this->handlePropertyValue(
177177 $object, $outputmode, $pr, $first_col, $hastitle, $hastime,
178 - $first_value, $isEventline, $curmeta, $curdata, $date_value
 178+ $first_value, $isEventline, $curmeta, $curdata, $date_value, $output
179179 );
180180 if ( $event !== false ) {
181181 $events[] = $event;
@@ -182,7 +182,7 @@
183183 $first_value = false;
184184 }
185185
186 - if ( $output ) $curdata .= "<br />";
 186+ if ( $output ) $curdata .= '<br />';
187187 $output = false;
188188 $first_col = false;
189189 }
@@ -248,11 +248,12 @@
249249 * @param string &$curmeta
250250 * @param string &$curdata
251251 * @param &$date_value
 252+ * @param boolean &$output
252253 *
253254 * @return false or array
254255 */
255256 protected function handlePropertyValue( SMWDataValue $object, $outputmode, SMWPrintRequest $pr, $first_col,
256 - &$hastitle, &$hastime, $first_value, $isEventline, &$curmeta, &$curdata, $date_value ) {
 257+ &$hastitle, &$hastime, $first_value, $isEventline, &$curmeta, &$curdata, $date_value, &$output ) {
257258
258259 $event = false;
259260

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81258Follow up to r81257jeroendedauw17:06, 31 January 2011

Status & tagging log