r81249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81248‎ | r81249 | r81250 >
Date:13:38, 31 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Reverting r81247, I really CBA
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialAddCollection.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialConceptMapping.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialCopy.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialDatasearch.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialExportTSV.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialImportLangNames.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialImportTSV.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialNeedsTranslation.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialOWStatistics.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialSelect.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialTransaction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/SpecialDatasearch.php
——@@ -3,7 +3,6 @@
44 if ( !defined( 'MEDIAWIKI' ) ) die();
55
66 $wgExtensionFunctions[] = 'wfSpecialDatasearch';
7 -$wgSpecialPages[] = 'SpecialDatasearch';
87
98 require_once( "Wikidata.php" );
109 require_once( "WikiDataGlobals.php" );
——@@ -361,4 +360,6 @@
362361 return $editor;
363362 }
364363 }
 364+
 365+ SpecialPage::addPage( new SpecialDatasearch() );
365366 }
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialImportLangNames.php
——@@ -6,9 +6,6 @@
77 $wgAvailableRights[] = 'languagenames';
88
99 $wgExtensionFunctions[] = 'wfSpecialImportLangNames';
10 -
11 - $wgSpecialPages[] = 'SpecialImportLangNames';
12 -
1310 function wfSpecialImportLangNames() {
1411 class SpecialImportLangNames extends SpecialPage {
1512 function SpecialImportLangNames() {
——@@ -160,5 +157,7 @@
161158 }
162159
163160 }
 161+
 162+ SpecialPage::addPage( new SpecialImportLangNames );
164163 }
165164
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialAddCollection.php
——@@ -7,7 +7,6 @@
88 $wgAvailableRights[] = 'addcollection';
99 $wgGroupPermissions['bureaucrat']['addcollection'] = true;
1010 $wgExtensionFunctions[] = 'wfSpecialAddCollection';
11 - $wgSpecialPages[] = 'SpecialAddCollection';
1211
1312 function wfSpecialAddCollection() {
1413 class SpecialAddCollection extends SpecialPage {
——@@ -55,5 +54,7 @@
5655 ) );
5756 }
5857 }
 58+
 59+ SpecialPage::addPage( new SpecialAddCollection );
5960 }
6061
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialNeedsTranslation.php
——@@ -3,8 +3,6 @@
44
55 $wgExtensionFunctions[] = 'wfSpecialNeedsTranslation';
66
7 - $wgSpecialPages[] = 'SpecialNeedsTranslation';
8 -
97 require_once( "Wikidata.php" );
108
119 function wfSpecialNeedsTranslation() {
——@@ -151,6 +149,8 @@
152150 $wgOut->addHTML( $editor->view( new IdStack( "expression" ), $recordSet ) );
153151 }
154152 }
 153+
 154+ SpecialPage::addPage( new SpecialNeedsTranslation );
155155 }
156156
157157
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialExportTSV.php
——@@ -8,8 +8,6 @@
99 $wgAvailableRights[] = 'exporttsv';
1010 $wgExtensionFunctions[] = 'wfSpecialExportTSV';
1111
12 - $wgSpecialPages[] = 'SpecialExportTSV';
13 -
1412 function wfSpecialExportTSV() {
1513 class SpecialExportTSV extends SpecialPage {
1614
——@@ -268,5 +266,7 @@
269267 return $fileName;
270268 }
271269 }
 270+
 271+ SpecialPage::addPage( new SpecialExportTSV );
272272 }
273273
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialSelect.php
——@@ -6,7 +6,6 @@
77 require_once( "Wikidata.php" );
88 require_once( "WikiDataGlobals.php" );
99
10 -$wgSpecialPages[] = 'SpecialSelect';
1110
1211 function wfSpecialSelect() {
1312 class SpecialSelect extends SpecialPage {
——@@ -25,6 +24,8 @@
2625 echo getSelectOptions();
2726 }
2827 }
 28+
 29+ SpecialPage::addPage( new SpecialSelect() );
2930 }
3031
3132 function getSelectOptions() {
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php
——@@ -4,8 +4,6 @@
55
66
77 $wgExtensionFunctions[] = 'wfSpecialSuggest';
8 -$wgSpecialPages[] = 'SpecialSuggest';
9 -
108 function wfSpecialSuggest() {
119 class SpecialSuggest extends SpecialPage {
1210 function SpecialSuggest() {
——@@ -34,6 +32,8 @@
3533 echo getSuggestions();
3634 }
3735 }
 36+
 37+ SpecialPage::addPage( new SpecialSuggest() );
3838 }
3939
4040 /**
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialTransaction.php
——@@ -3,8 +3,6 @@
44 if ( !defined( 'MEDIAWIKI' ) ) die();
55
66 $wgExtensionFunctions[] = 'wfSpecialTransaction';
7 -$wgSpecialPages[] = 'SpecialTransaction';
8 -
97 require_once( "Wikidata.php" );
108 require_once( "Utilities.php" );
119
——@@ -92,6 +90,8 @@
9391 $wgOut->addHTML( "<script language='javascript'>/* <![CDATA[ */\nexpandEditors();\n/* ]]> */</script>" );
9492 }
9593 }
 94+
 95+ SpecialPage::addPage( new SpecialTransaction() );
9696 }
9797
9898 function getFilterOptionsPanel( $fromTransactionId, $transactionCount, $userName, $showRollBackOptions ) {
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialOWStatistics.php
——@@ -3,8 +3,6 @@
44
55 $wgExtensionFunctions[] = 'wfSpecialOWStatistics';
66
7 - $wgSpecialPages[] = 'SpecialOWStatistics';
8 -
97 require_once( "Wikidata.php" );
108 require_once( 'languages.php' );
119
——@@ -257,4 +255,6 @@
258256 }
259257
260258 }
 259+ SpecialPage::addPage( new SpecialOWStatistics );
 260+
261261 }
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialImportTSV.php
——@@ -8,8 +8,6 @@
99 $wgAvailableRights[] = 'importtsv';
1010 $wgExtensionFunctions[] = 'wfSpecialImportTSV';
1111
12 - $wgSpecialPages[] = 'SpecialImportTSV';
13 -
1412 function wfSpecialImportTSV() {
1513 class SpecialImportTSV extends SpecialPage {
1614
——@@ -241,5 +239,7 @@
242240 }
243241
244242 }
 243+
 244+ SpecialPage::addPage( new SpecialImportTSV );
245245 }
246246
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialConceptMapping.php
——@@ -18,8 +18,6 @@
1919 'author' => 'Kim Bruning',
2020 );
2121
22 -$wgSpecialPages[] = 'SpecialConceptMapping';
23 -
2422 function wfSpecialConceptMapping() {
2523 require_once( "Wikidata.php" );
2624 require_once( "WikiDataAPI.php" );
——@@ -200,5 +198,8 @@
201199 }
202200
203201 }
 202+
 203+ SpecialPage::addPage( new SpecialConceptMapping );
 204+
204205 }
205206
Index: trunk/extensions/Wikidata/OmegaWiki/SpecialCopy.php
——@@ -23,8 +23,6 @@
2424 'author' => 'Alan Smithee',
2525 );
2626
27 -$wgSpecialPages[] = 'SpecialCopy';
28 -
2927 function wfSpecialCopy() {
3028 require_once( "Wikidata.php" );
3129 require_once( "WikiDataAPI.php" );
——@@ -172,5 +170,7 @@
173171
174172 }
175173 }
 174+ SpecialPage::addPage( new SpecialCopy );
 175+
176176 }
177177

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81247This extension fucking sucks. Seriously, how are you including special pages?...reedy13:02, 31 January 2011

Status & tagging log