r81242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81241‎ | r81242 | r81243 >
Date:12:24, 31 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Per bug 27041, remove calls to $dbr->immediateBegin();

Not replaced, as it's creating a transaction on a DB slave, so no need to
Modified paths:
  • /trunk/extensions/DSMW/includes/IntegrationFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DSMW/includes/IntegrationFunctions.php
@@ -207,7 +207,6 @@
208208 $indexNS = 0;
209209 wfDebugLog( 'p2p', ' - function logootIntegrate : ' . $article );
210210 $dbr = wfGetDB( DB_SLAVE );
211 - $dbr->immediateBegin();
212211 if ( is_string( $article ) ) {
213212 // if there is a space in the title, repalce by '_'
214213 $article = str_replace( " ", "_", $article );
@@ -296,7 +295,6 @@
297296 */
298297 function logootIntegrateAtt( $article, $edit ) {
299298 $dbr = wfGetDB( DB_SLAVE );
300 - $dbr->immediateBegin();
301299 $title = Title::newFromText( $article );
302300 $lastRevision = Revision::loadFromTitle( $dbr, $title );
303301

Follow-up revisions

RevisionCommit summaryAuthorDate
r81243bug 27041, replace call to SiteStats::admins() to SiteStats::numberingroup( '...reedy12:26, 31 January 2011
r81244bug 27041, swap Database::newFromParams to DatabaseBase::newFromType()reedy12:34, 31 January 2011
r81245bug 27041, kill Image::__constructreedy12:45, 31 January 2011
r81248bug 27041, SpecialPage:addPage is deprecated...reedy13:17, 31 January 2011
r813941.17: MFT r81026, r81116, r81155, r81201, r81204, r81205, r81220, r81235, r81...catrope15:33, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81220Part of bug 27041, removing all calls to escapeLike in extensionsreedy22:34, 30 January 2011
r81241bug 27041, fixup usages of userMailer()reedy12:21, 31 January 2011

Status & tagging log