r81140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81139‎ | r81140 | r81141 >
Date:17:34, 28 January 2011
Author:platonides
Status:ok
Tags:
Comment:
Remove empty statement (r80993) and unused global (r80766).
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
@@ -661,7 +661,7 @@
662662 * @return File: stashed file
663663 */
664664 public function stashSessionFile( $key = null ) {
665 - $stash = RepoGroup::singleton()->getLocalRepo()->getUploadStash();;
 665+ $stash = RepoGroup::singleton()->getLocalRepo()->getUploadStash();
666666 $data = array(
667667 'mFileProps' => $this->mFileProps,
668668 'mSourceType' => $this->getSourceType(),
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -558,7 +558,7 @@
559559 * @param $details Array: result of UploadBase::verifyUpload
560560 */
561561 protected function processVerificationError( $details ) {
562 - global $wgFileExtensions, $wgLang;
 562+ global $wgFileExtensions;
563563
564564 switch( $details['status'] ) {
565565

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80766(bug 26809) Uploading files with multiple extensions where one of the extensi...btongminh20:33, 22 January 2011
r80993Make the UploadStash repo specific by creating FileRepo::getUploadStash(). In...btongminh21:26, 25 January 2011

Status & tagging log