r81134 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81133‎ | r81134 | r81135 >
Date:15:25, 28 January 2011
Author:demon
Status:deferred
Tags:
Comment:
Followup r81132, missed some more ts2 removal
Modified paths:
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/PostgresUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/PostgresUpdater.php
@@ -514,7 +514,7 @@
515515 * Verify that this user is configured correctly
516516 */
517517 protected function checkPgUser() {
518 - global $wgDBmwschema, $wgDBts2schema, $wgDBuser;
 518+ global $wgDBmwschema, $wgDBuser;
519519
520520 $config = $this->db->selectField(
521521 'pg_catalog.pg_user', "array_to_string(useconfig,'*')",
@@ -536,10 +536,6 @@
537537 $this->output( "Adding in schema \"$wgDBmwschema\" to search_path for user \"$wgDBuser\"\n" );
538538 $search_path = "$wgDBmwschema, $search_path";
539539 }
540 - if ( strpos( $search_path, $wgDBts2schema ) === false ) {
541 - $this->output( "Adding in schema \"$wgDBts2schema\" to search_path for user \"$wgDBuser\"\n" );
542 - $search_path = "$search_path, $wgDBts2schema";
543 - }
544540 $search_path = str_replace( ', ,', ',', $search_path );
545541 if ( array_key_exists( 'search_path', $conf ) === false || $search_path != $conf['search_path'] ) {
546542 $this->db->query( "ALTER USER $wgDBuser SET search_path = $search_path" );
Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -21,7 +21,6 @@
2222 'wgDBuser',
2323 'wgDBpassword',
2424 'wgDBmwschema',
25 - 'wgDBts2schema',
2625 );
2726
2827 var $minimumVersion = '8.3';
@@ -288,12 +287,10 @@
289288 function getLocalSettings() {
290289 $port = $this->getVar( 'wgDBport' );
291290 $schema = $this->getVar( 'wgDBmwschema' );
292 - $ts2 = $this->getVar( 'wgDBts2schema' );
293291 return
294292 "# Postgres specific settings
295293 \$wgDBport = \"{$port}\";
296 -\$wgDBmwschema = \"{$schema}\";
297 -\$wgDBts2schema = \"{$ts2}\";";
 294+\$wgDBmwschema = \"{$schema}\";";
298295 }
299296
300297 public function preUpgrade() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81132Per comment on bug 26612, we should drop the pre-Postgres 8.3 support with th...demon14:12, 28 January 2011

Status & tagging log