r81096 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81095‎ | r81096 | r81097 >
Date:17:47, 27 January 2011
Author:neilk
Status:deferred
Tags:
Comment:
removing Location support, confuses some browsers and is a bit baroque anyway
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.Uri.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.Uri.js
@@ -53,7 +53,7 @@
5454 /**
5555 * Constructs URI object. Throws error if arguments are illegal/impossible, or otherwise don't parse.
5656 * @constructor
57 - * @param {!Object|Location|String} URI string, or a Location object (obtained from window.location in some browsers) or an Object with appropriate properties (especially another URI object to clone). Object must have non-blank 'protocol', 'host', and 'path' properties.
 57+ * @param {!Object|String} URI string, or an Object with appropriate properties (especially another URI object to clone). Object must have non-blank 'protocol', 'host', and 'path' properties.
5858 * @param {Boolean} strict mode (when parsing a string)
5959 */
6060 mw.Uri = function( uri, strictMode ) {
@@ -61,8 +61,6 @@
6262 if ( mw.isFull( uri ) ) {
6363 if ( typeof uri === 'string' ) {
6464 this._parse( uri, strictMode );
65 - } else if ( uri instanceof Location ) {
66 - this._parse( uri.href, strictMode );
6765 } else if ( typeof uri === 'object' ) {
6866 var _this = this;
6967 $.each( this._properties, function( i, property ) {

Status & tagging log